Login | Register
My pages Projects Community openCollabNet

Discussions > users [DISABLED] > Re: Code Reviewing

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: Code Reviewing

Author markphip
Full name Mark Phippard
Date 2009-01-28 07:17:25 PST
Message On Wed, Jan 28, 2009 at 10:09 AM, David Weintraub <qazwart at gmail dot com> wrote:
> A little dilemma here:
>
> Our developers want to do code reviews, but they want to be able to
> check in the code before the review, so a tool like Crucible can help
> with the code reviews. This means that code checked into Subversion
> may not necessarily be good code and should not be in the project.
>
> Several proposals have been talked about: Using a promotion branching
> scheme (code would be worked on a "Development Branch" and then merged
> to an "Integration Branch" when the code is approved). Using a second
> repository (code in the first repository would be reviewed, and when
> approved, those changes would be placed in a second repository). Or,
> some other scheme to keep the code in Subversion's trunk from getting
> contaminated with bad code.
>
> How do you handle code review in Subversion? TeamFoundation has
> something called a "shelf" that seems to be able to handle something
> like this. Is there a similar concept in Subversion?

Not sure if this helps, but have you looked at TeamCity?

http://www.jetbrains​.com/teamcity/

Setting that option aside, I wrote a blog post a couple years ago
about how you could approximate shelves using Subversion.

--
Thanks

Mark Phippard
http://markphip.blogspot.com/

« Previous message in topic | 3 of 10 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
Code Reviewing David Weintraub <qazwart at gmail dot com> David Weintraub <qazwart at gmail dot com> 2009-01-28 07:09:23 PST
     Re: Code Reviewing comargo Cyril Margorin 2009-01-28 07:15:15 PST
     Re: Code Reviewing markphip Mark Phippard 2009-01-28 07:17:25 PST
     RE: Code Reviewing pilotbob Bob Archer 2009-01-28 07:43:47 PST
         Re: Code Reviewing David Weintraub <qazwart at gmail dot com> David Weintraub <qazwart at gmail dot com> 2009-01-28 09:58:47 PST
             Re: Code Reviewing markphip Mark Phippard 2009-01-28 10:07:43 PST
                 Re: Code Reviewing bjz Blair Zajac 2009-01-28 12:16:14 PST
                     Re: Code Reviewing David Weintraub <qazwart at gmail dot com> David Weintraub <qazwart at gmail dot com> 2009-01-29 09:40:07 PST
                         RE: Code Reviewing pilotbob Bob Archer 2009-01-29 13:28:13 PST
                             Re: Code Reviewing David Weintraub <qazwart at gmail dot com> David Weintraub <qazwart at gmail dot com> 2009-01-30 06:12:46 PST
Messages per page: