Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: Branching 1.6.x this week (dirent_uri)

subversion
Discussion topic

Back to topic list

Re: Branching 1.6.x this week (dirent_uri)

Author julianfoad
Full name Julian Foad
Date 2009-01-07 09:43:40 PST
Message On Sat, 2008-11-15 at 22:41 +0100, Lieven Govaerts wrote:
> Bert Huijben wrote:
> >> -----Original Message-----
> >> From: Lieven Govaerts [mailto:svnlgo{a}mobsol.be]
> >> Sent: maandag 10 november 2008 20:32
> >> To: dev at subversion dot tigris dot org
> >> Subject: Re: Branching 1.6.x this week
> >>
> >>
> >> So, I haven't had time to finish the dirent_uri stuff which I started
> >> to
> >> add during the month October. The problem is that the new interface
> >> isn't finished, and AFAIC shouldn't be exposed yet.
> >>
> >> I don't have time to make this change in the coming days or weeks, so
> >> I'd like to ask if someone can move the file dirent_uri.h out of the
> >> public area (except for svn_dirent_is_root). That should do it
> >> normally.
> >> This gives me some time to finish it up before 1.7.
> >
> > Hi Lieven,
> >
> > What are the open issues on this? Is it possible for somebody else to
> > resolve the few loose ends there are?
> >
>
> Well, since the svn_[dirent|uri] stuff is a whole new API, now might be
> a good moment to make sure that API is better than the original. So,
> things like passing a pool parameter, return svn_error_t on all
> functions etc.
>
> Besides that, the API is not complete yet. For some functions we have
> the svn_uri variant but not svn_dirent or visa versa.
> Then there is the is_absolute function, which thinks "E:foo" is an
> absolute path.
>
> > The code is in use in quite some places (the old public api uses the new
> > functions), but there are other places that use the old api that indirectly
> > calls svn_dirent*.
>
> I thought only svn_dirent_is_root is used in other places than path.c.
>
> >
> > When I look through it, it seems most dirent and url public api's are
> > completed, but are not used everywhere they should. Doing a massive rename
> > to make the api internal just to make it public in 1.7 doesn't feel ok.
> >
>
> I'm more afraid that we'd introduce an API that isn't finished yet,
> which we have to rev in 1.7. My plan was to deprecate svn_path* at the
> same time as we introduce svn_[dirent|uri].
>
> Lieven

Looks like this should be a TODO-1.6 item. Adding it...

- Julian

« Previous message in topic | 14 of 17 | Next message in topic »

Messages

Show all messages in topic

Branching 1.6.x this week "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2008-11-10 08:57:47 PST
     Re: Branching 1.6.x this week gstein Greg Stein 2008-11-10 09:05:10 PST
         Re: Branching 1.6.x this week "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2008-11-10 09:16:12 PST
             Re: Branching 1.6.x this week brane Branko Cibej 2008-11-11 07:04:54 PST
                 Re: Branching 1.6.x this week cmpilato C. Michael Pilato 2008-11-11 07:16:59 PST
                     Re: Branching 1.6.x this week kfogel Karl Fogel 2008-11-12 06:53:21 PST
     Re: Branching 1.6.x this week Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2008-11-10 10:05:37 PST
         Re: Branching 1.6.x this week "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2008-11-10 10:29:42 PST
             Re: Branching 1.6.x this week Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2008-11-10 10:40:08 PST
     Re: Branching 1.6.x this week Lieven Govaerts <svnlgo at mobsol dot be> Lieven Govaerts <svnlgo at mobsol dot be> 2008-11-10 11:31:40 PST
         RE: Branching 1.6.x this week (dirent_uri) Bert Huijben <b dot huijben at competence dot biz> Bert Huijben <b dot huijben at competence dot biz> 2008-11-13 06:28:56 PST
         Re: Branching 1.6.x this week (dirent_uri) Lieven Govaerts <svnlgo at mobsol dot be> Lieven Govaerts <svnlgo at mobsol dot be> 2008-11-15 13:41:33 PST
             Re: Branching 1.6.x this week (dirent_uri) gstein Greg Stein 2008-11-15 19:23:47 PST
             Re: Branching 1.6.x this week (dirent_uri) julianfoad Julian Foad 2009-01-07 09:43:40 PST
     Re: Branching 1.6.x this week "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2008-11-13 06:36:13 PST
         Re: Branching 1.6.x this week gstein Greg Stein 2008-11-13 11:57:44 PST
         Re: Branching 1.6.x this week danielsh Daniel Shahaf 2008-11-13 12:28:24 PST
Messages per page: