Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr

subversion
Discussion topic

Back to topic list

Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr

Author julianfoad
Full name Julian Foad
Date 2009-01-08 06:34:58 PST
Message Senthil Kumaran S wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
> > svn_auth_get_platfor​m_specific_client_pr​oviders() and
> > svn_auth_get_platfor​m_specific_provider(​) could accept additional
> > 'svn_boolean_t command_line' argument. If 'command_line==TRUE', then
> > svn_auth_get_gnome_k​eyring_simple_provid​er() would be called with
> > unlock_prompt_func==NULL and prompt_baton==NULL.
>
> That is a good one, I shall come up with a patch with the above idea :)

Instead of this function having internal knowledge of a particular
command-line prompting function, it would be better for it to take a
pointer to a prompting function and have no internal knowledge. (The
file "auth.c" should not have to include "svn_cmdline.h".)

- Julian

« Previous message in topic | 6 of 10 | Next message in topic »

Messages

Show all messages in topic

RE: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr rhuijben Bert Huijben 2009-01-07 06:15:04 PST
     Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr stylesen Senthil Kumaran S 2009-01-08 01:16:02 PST
         Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr arfrever Arfrever Frehtes Taifersar Arahesis 2009-01-08 03:48:30 PST
             Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr arfrever Arfrever Frehtes Taifersar Arahesis 2009-01-08 03:50:40 PST
             Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr stylesen Senthil Kumaran S 2009-01-08 03:59:39 PST
                 Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr julianfoad Julian Foad 2009-01-08 06:34:58 PST
                     Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-01-08 07:14:40 PST
                     Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr stylesen Senthil Kumaran S 2009-01-09 06:12:36 PST
             Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr stylesen Senthil Kumaran S 2009-01-09 06:11:17 PST
             Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr stylesen Senthil Kumaran S 2009-01-12 02:02:02 PST
Messages per page: