Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35144 - trunk/subversion/include

subversion
Discussion topic

Back to topic list

Re: svn commit: r35144 - trunk/subversion/include

Author julianfoad
Full name Julian Foad
Date 2009-01-12 05:18:43 PST
Message On Sun, 2009-01-11 at 05:14 -0800, Bert Huijben wrote:
> Author: rhuijben
> Date: Sun Jan 11 05:14:59 2009
> New Revision: 35144
>
> Log:
> * subversion/include/svn_error.h
> (SVN_ERR_MALFUNCTION​_NO_RETURN): Make the loop containing abort() run
> infinately to help compilers that don't recognize abort() behavior
> see that this code never returns.
>
> Modified:
> trunk/subversion/inc​lude/svn_error.h
>
> Modified: trunk/subversion/inc​lude/svn_error.h
> URL: http://svn.collab.ne​t/viewvc/svn/trunk/s​ubversion/include/sv​n_error.h?pathrev=35​144&r1=35143​&r2=35144
> ====================​====================​====================​==================
> --- trunk/subversion/inc​lude/svn_error.h Sat Jan 10 15:54:46 2009 (r35143)
> +++ trunk/subversion/inc​lude/svn_error.h Sun Jan 11 05:14:59 2009 (r35144)
> @@ -365,7 +365,7 @@ svn_handle_warning(FILE *stream,
> do { \
> svn_error__malfunction(FALSE, __FILE__, __LINE__, NULL); \
> abort(); \
> - } while (0)
> + } while (1)
>

Please add a comment explaining that, as otherwise that code looks
wrong.

- Julian

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r35144 - trunk/subversion/include julianfoad Julian Foad 2009-01-12 05:18:43 PST
Messages per page: