Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf

subversion
Discussion topic

Back to topic list

Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf

Author cmpilato
Full name C. Michael Pilato
Date 2009-01-13 13:37:10 PST
Message Ben Collins-Sussman wrote:
> On Fri, Jan 9, 2009 at 11:33 AM, Ben Collins-Sussman
> <sussman at red-bean dot com> wrote:
>
>> is an interesting problem. Perhaps we want to distinguish
>> two sorts of callers:
>>
>> * clients who are calling svn_ra_get_youngest_revnum()
>> * internal serf routines who need to know what HEAD is
>>
>> The former audience needs a network request to happen, but the latter
>> audience is generally fine with using the "latest cached" value. So
>> I could revert this bit of change which makes youngest_revnum() look
>> for a cached value, and move that logic into a helper function
>> instead, used by other serf routines.
>
> OK, I've done this in r35220. Serf's implementation of the public
> svn_ra_get_youngest_revnum() *always* makes a network request, so that
> there's no chance of getting a stale HEAD value. I created a new
> internal func which attempts to try the cached HEAD first.
>
> Ironically, after all this work, I can't find a single bit of interal
> serf code that needs to discover HEAD, other than (maybe?)
> svn_ra_serf__get_dir(). Is that a reasonable candidate for "just
> used the latest cached value of HEAD"?

No implementation of an RA API should be allowed to use a stale value for
HEAD. Subversion != svn, and GUI clients that keep the libraries loaded
(and such HEAD-revision caches populated) should not be cheated of accurate
information when they hit our APIs. Valid uses of such a cache are strictly
limited to those which consult the cache *only* after *themselves* first
refreshing said cache with an actual repository query.

--
C. Michael Pilato <cmpilato at collab dot net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Attachments

« Previous message in topic | 11 of 18 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf gstein Greg Stein 2008-12-24 08:56:25 PST
     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2008-12-24 10:45:37 PST
         Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf gstein Greg Stein 2008-12-25 00:06:23 PST
     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf pretzelgod Eric Gillespie 2008-12-25 02:18:30 PST
         Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2009-01-09 09:33:55 PST
             Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf gstein Greg Stein 2009-01-09 10:24:02 PST
                 Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2009-01-09 13:22:54 PST
                     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf gstein Greg Stein 2009-01-09 14:10:42 PST
                         Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf cmpilato C. Michael Pilato 2009-01-12 06:25:48 PST
             Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2009-01-13 13:30:03 PST
                 Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf cmpilato C. Michael Pilato 2009-01-13 13:37:10 PST
                     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2009-01-13 14:13:16 PST
                     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf gstein Greg Stein 2009-01-13 15:23:00 PST
                         Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf pretzelgod Eric Gillespie 2009-01-13 17:22:47 PST
                             Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf jerenkrantz Justin Erenkrantz 2009-01-13 18:10:31 PST
                                 Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf pretzelgod Eric Gillespie 2009-01-13 18:38:27 PST
                                 Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf sussman Ben Collins-Sussman 2009-01-13 21:12:31 PST
                                     Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf cmpilato C. Michael Pilato 2009-01-14 05:23:02 PST
Messages per page: