Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] calling diff_summarize from SVN Perl bindings

subversion
Discussion topic

Back to topic list

Re: [PATCH] calling diff_summarize from SVN Perl bindings

Author julianfoad
Full name Julian Foad
Date 2009-01-20 02:26:07 PST
Message I have checked that the patch builds against current trunk, but I don't
understand SWIG so need someone else to review/test/commit it.

I have attached the latest version of the patch (with the POD fix, from
from Mon, 19 Jan 2009 21:08:59 +0800) as a diff against trunk@35343,
with the log message included (tweaked just a little).


Hyrum K. Wright wrote:
> Daniel Shahaf wrote:
> > Good point. @James: yes, please verify that the patch still applies and
> > to trunk works as intended. (I see that you have already fixed the tabs
> > issue.)
> >
> > Also, for next time, it's better to send patches using a text/* MIME type,
> > rather than 'application/octet-stream' as you did. (Sometimes, naming the
> > patch file with a '.txt' extension causes 'text/plain' to be used.)
>
> One more suggestion: include a log message. From HACKING: "Please include a log
> message with your patch. A good log message helps potential reviewers understand
> the changes in your patch, and increases the likelihood that it will be
> applied." You can find the log message guidelines here:
> http://subversion.ti​gris.org/hacking.htm​l#log-messages

James did include a log message initially, he just forgot to re-send it
with the updated patches. It looks the updates will not require a change
to the log message.

> -Hyrum
>
> PS - Please don't feel like we're trying to emphasis process over substance.
> That's not the point! We've just discovered over the years that these processes
> help improve the quality of the software, and that encouraging new contributors
> to follow them early on creates better maintainers in the future. Thanks for
> the patches!

Yes, indeed. Sorry for the large number of emails about this. Thanks for
the patches!

- Julian
Attachments

« Previous message in topic | 9 of 14 | Next message in topic »

Messages

Show all messages in topic

[PATCH] calling diff_summarize from SVN Perl bindings "James Fang" <june dot fang at gmail dot com> "James Fang" <june dot fang at gmail dot com> 2009-01-15 02:00:37 PST
     Re: [PATCH] calling diff_summarize from SVN Perl bindings "James Fang" <june dot fang at gmail dot com> "James Fang" <june dot fang at gmail dot com> 2009-01-18 04:46:40 PST
         Re: [PATCH] calling diff_summarize from SVN Perl bindings Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-18 10:03:28 PST
             Re: [PATCH] calling diff_summarize from SVN Perl bindings julianfoad Julian Foad 2009-01-19 01:03:51 PST
                 Re: [PATCH] calling diff_summarize from SVN Perl bindings "James Fang" <june dot fang at gmail dot com> "James Fang" <june dot fang at gmail dot com> 2009-01-19 05:01:42 PST
                     Re: [PATCH] calling diff_summarize from SVN Perl bindings "James Fang" <june dot fang at gmail dot com> "James Fang" <june dot fang at gmail dot com> 2009-01-19 05:09:00 PST
                 Re: [PATCH] calling diff_summarize from SVN Perl bindings Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-19 09:23:50 PST
                     Re: [PATCH] calling diff_summarize from SVN Perl bindings "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-01-19 11:10:51 PST
                         Re: [PATCH] calling diff_summarize from SVN Perl bindings julianfoad Julian Foad 2009-01-20 02:26:07 PST
                             Re: [PATCH] calling diff_summarize from SVN Perl bindings julianfoad Julian Foad 2009-01-20 03:30:15 PST
                                 Re: [PATCH] calling diff_summarize from SVN Perl bindings James Fang <june dot fang at gmail dot com> James Fang <june dot fang at gmail dot com> 2009-01-21 04:56:03 PST
                                     Re: [PATCH] calling diff_summarize from SVN Perl bindings julianfoad Julian Foad 2009-01-21 06:48:07 PST
                                 Re: [PATCH] calling diff_summarize from SVN Perl bindings James Fang <june dot fang at gmail dot com> James Fang <june dot fang at gmail dot com> 2009-02-06 00:57:14 PST
                                     Re: [PATCH] calling diff_summarize from SVN Perl bindings julianfoad Julian Foad 2009-02-06 06:55:12 PST
Messages per page: