Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

Author "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Full name "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Date 2009-01-24 18:19:59 PST
Message Bert Huijben wrote:
>> -----Original Message-----
>> From: Hyrum K. Wright [mailto:hyrum at hyrumwright dot org]
>> Sent: Friday, January 23, 2009 9:39 PM
>> To: svn at subversion dot tigris dot org
>> Subject: svn commit: r35435 - in trunk/subversion: include/private
>> libsvn_subr
>>
>> Author: hwright
>> Date: Fri Jan 23 12:39:08 2009
>> New Revision: 35435
>>
>> Log:
>> Update sqlite vararg binding to bind blobs.
>>
>> * subversion/libsvn_subr/sqlite.c
>> (vbindf): Use 'b' for blob values.
>>
>> * subversion/include/p​rivate/svn_sqlite.h
>> (svn_sqlite__bindf): Update docs.
>>
>> Modified:
>> trunk/subversion/inc​lude/private/svn_sql​ite.h
>> trunk/subversion/lib​svn_subr/sqlite.c
>>
>> Modified: trunk/subversion/inc​lude/private/svn_sql​ite.h
>> URL:
>> http://svn.collab.ne​t/viewvc/svn/trunk/s​ubversion/include/pr​ivate/svn_s
>> qlite.h?pathrev=3543​5&r1=35434&r​2=35435
>> ====================​====================​====================​===========
>> =======
>> --- trunk/subversion/inc​lude/private/svn_sql​ite.h Fri Jan 23
>> 12:34:18 2009 (r35434)
>> +++ trunk/subversion/inc​lude/private/svn_sql​ite.h Fri Jan 23
>> 12:39:08 2009 (r35435)
>> @@ -102,6 +102,8 @@ svn_sqlite__prepare(​svn_sqlite__stmt_t *
>> ---- ----------------- ---------
>> i apr_int64_t Number
>> s const char ** String
>> + b const void * Blob (must be followed by an additional
>> argument
>> + with the number of bytes in the
>> object)
>
> I think you should also document the type of the length value as apr_size_t
> here.

Agreed. r35447.

-Hyrum

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

RE: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr rhuijben Bert Huijben 2009-01-23 15:13:12 PST
     Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-01-24 18:19:59 PST
Messages per page: