Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35446 - trunk/subversion/libsvn_diff

subversion
Discussion topic

Back to topic list

Re: svn commit: r35446 - trunk/subversion/libsvn_diff

Author Daniel Shahaf <d dot s at daniel dot shahaf dot name>
Full name Daniel Shahaf <d dot s at daniel dot shahaf dot name>
Date 2009-01-24 22:23:39 PST
Message > @@ -1074,6 +1075,14 @@ output_unified_diff_​modified(void *baton
> {
> output_baton->hun​k_extra_context[--p]​ = '\0';
> }
> + const char *invalid_character =
> + svn_utf__last_valid(​output_baton->hun​k_extra_context,
> + SVN_DIFF__EXTRA_CONTEXT_LENGTH - 1);

s/SVN_DIFF__EXTRA_CO​NTEXT_LENGTH - 1/SVN_DIFF__EXTRA_CO​NTEXT_LENGTH + 1/ ?

Notice that it's declared as:

  char hunk_extra_context[S​VN_DIFF__EXTRA_CONTE​XT_LENGTH + 1];

and svn_utf__last_valid() does

    consr char *p = data;
    while (p++ < data + len)
      ...

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r35446 - trunk/subversion/libsvn_diff Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-24 22:23:39 PST
     Re: svn commit: r35446 - trunk/subversion/libsvn_diff arfrever Arfrever Frehtes Taifersar Arahesis 2009-01-25 07:30:56 PST
         Re: svn commit: r35446 - trunk/subversion/libsvn_diff Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-25 15:56:48 PST
Messages per page: