Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

subversion
Discussion topic

Back to topic list

Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

Author "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Full name "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Date 2009-01-28 21:16:09 PST
Message Daniel Shahaf wrote:
> Hyrum K. Wright wrote on Wed, 28 Jan 2009 at 15:15 -0800:
>> Greg Stein wrote:
>>> On Wed, Jan 28, 2009 at 20:48, Daniel Shahaf <d dot s at daniel dot shahaf dot name> wrote:
>>>> On Fri, 23 Jan 2009 12:39 -0800, "Hyrum K. Wright"
>>>> <hyrum at hyrumwright dot org> wrote:
>>>>> + case 'b':
>>>>> + SVN_ERR(svn_sqlite__​bind_blob(stmt, count,
>>>>> + va_arg(ap, const void *),
>>>>> + va_arg(ap, apr_size_t)));
>>>>> + break;
>>>>> +
>>>> Can we use two va_arg() calls inside the function call? IIRC, the order
>>>> of evaluation of parameters to a function call is not defined...
>>> Agreed. I mentioned the same thing to Hyrum on IRC, but he either
>>> missed it, or labeled me a lunatic and ignored me. :-P
>> Let's just say I missed it and move along. :)
>
> Another thing Greg mentioned on IRC was the need to add parentheses
> around the definition of the MAYBE_ALLOC() macro. Haven't seen it
> resolved (but I disconnected shortly after that).

I just double checked, and that's been taken care of. (For those keeping score
at home, this macro is on the explore-wc branch in subversion/libsvn_wc/entries.c)

-Hyrum

« Previous message in topic | 5 of 6 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr "Daniel Shahaf" <d dot s at daniel dot shahaf dot name> "Daniel Shahaf" <d dot s at daniel dot shahaf dot name> 2009-01-28 11:48:03 PST
     Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr gstein Greg Stein 2009-01-28 15:08:33 PST
         Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-01-28 15:15:06 PST
             Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-28 20:56:26 PST
                 Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-01-28 21:16:09 PST
                     Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-01-28 21:20:17 PST
Messages per page: