Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs

Author "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Full name "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu>
Date 2009-02-09 07:22:41 PST
Message Hyrum K. Wright wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
>> 2009-02-09 03:38:18 Hyrum K. Wright napisaƂ(a):
>>> Arfrever Frehtes Taifersar Arahesis wrote:
>>>> Author: arfrever
>>>> Date: Sun Feb 8 18:36:08 2009
>>>> New Revision: 35748
>>>>
>>>> Log:
>>>> Use '.sql_h' filename extension for headers generated from '.sql' files.
>>> Yes, but Why?
>> This filename extension (or .sql.h) allows to easier distinguish headers generated from .sql files.
>
> Does the text "This file is automatically generated from foo.sql" not accomplish
> the same goal? Why not encode this redundancy in the source file, or even the
> source file name (e.g., rep-cache-db.sql) instead of in *two* different
> locations in the build system? It seems a bit redundant and cryptic.
>
> Btw, I had this conversation with somebody in IRC (and maybe should have
> recorded it here) when the change was made from .sql.h to .h. I originally felt
> that we should munge the output filename somehow, but further consideration has
> led me to be against such.

One more problem: we lose automatic syntax highlighting with the munged
extension. Can you please further justify this change, or revert it?

Thanks,
-Hyrum

« Previous message in topic | 4 of 14 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-08 18:38:29 PST
     Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs arfrever Arfrever Frehtes Taifersar Arahesis 2009-02-08 19:12:39 PST
         Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-08 19:26:48 PST
             Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-09 07:22:41 PST
                 Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs arfrever Arfrever Frehtes Taifersar Arahesis 2009-02-09 09:35:11 PST
                     Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-09 10:31:17 PST
                         Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs julianfoad Julian Foad 2009-02-09 10:59:46 PST
                         Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs peters Peter Samuelson 2009-02-09 20:33:55 PST
                             Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs gstein Greg Stein 2009-02-09 20:43:54 PST
                                 Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-10 12:21:19 PST
                                     Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs jerenkrantz Justin Erenkrantz 2009-02-11 06:36:34 PST
                                         Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-12 06:36:07 PST
                                             Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> "Hyrum K dot Wright" <hyrum_wright at mail dot utexas dot edu> 2009-02-13 07:35:30 PST
         Re: svn commit: r35748 - in trunk: . build/generator subversion/libsvn_fs_fs julianfoad Julian Foad 2009-02-09 02:46:26 PST
Messages per page: