Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: export of invalid revision (issue #3400)

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: export of invalid revision (issue #3400)

Author e_wong
Full name Edmund Wong
Date 2009-04-15 08:12:36 PDT
Message Bert Huijben wrote:

>> I would call these bugs.
>
> Confirmed on svn 1.6.1. Also with svn info.
>
> I'm not sure if I would call it a bug; moving this thread to dev@s.t.o for
> further discussion on whether this is a bug or not.

I suppose it depends on one's preference to how to take
that 10000 or whatever number is being used and is way
more than the current revision.

1) Assume the user meant that he/she wanted the latest
    revision but can't be bothered to find it out the
    hard way. (Newbie question: How does one find out
    what the latest revision is, aside for doing a
    'svn update'?)

2) Assume the user didn't know what was going on and
    give him/her an error :

     "You've given me an invalid revision number."

The important issue here is consistency, IMHO. A consistent
behaviour of dealing with invalid (again, depends on
point of view) input will help subversion be more
effective. Just my $0.02.

>
> All these functions use svn_client__ra_sessi​on_from_path() to parse the
> revision conversion. This in turn calls svn_client__get_revi​sion_number()
> which has this code fragment:

But what I DO know from this issue and your response to
it is the following:

   1) I still have WAYS to go in figuring this code out.
   2) I was barking up the wrong tree. I was looking at
      the source code under libsvn_client/ and svn/.

> /* Final check -- if our caller provided a youngest revision, and
> the number we wound up with is younger than that revision, we need
> to stick to our caller's idea of "youngest". */
> if (youngest_rev
> && SVN_IS_VALID_REVNUM(​*youngest_rev)
> && SVN_IS_VALID_REVNUM(*revnum)
> && (*revnum > *youngest_rev))
> *revnum = *youngest_rev;
>

In any event, *if* it is a bug, would it be considered
a bite-sized one? (This is coming from someone looking
for 'easy' bite-size tasks without being too overwhelmed.
i.e. issue 3342, which I'm still pondering.)

Again, just my humble $0.02.

Edmund

« Previous message in topic | 2 of 5 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
RE: export of invalid revision (issue #3400) rhuijben Bert Huijben 2009-04-15 07:08:00 PDT
     Re: export of invalid revision (issue #3400) e_wong Edmund Wong 2009-04-15 08:12:36 PDT
         Re: export of invalid revision (issue #3400) jpeacock John Peacock 2009-04-15 08:22:54 PDT
             Re: export of invalid revision (issue #3400) e_wong Edmund Wong 2009-04-15 08:34:20 PDT
         RE: export of invalid revision (issue #3400) rhuijben Bert Huijben 2009-04-15 08:35:19 PDT
Messages per page: