Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header

subversion
Discussion topic

Back to topic list

Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header

Author gstein
Full name Greg Stein
Date 2009-05-06 05:50:40 PDT
Message On Wed, May 6, 2009 at 14:46, Hyrum K. Wright
<hyrum_wright@mai​l.utexas.edu> wrote:
>
> On May 6, 2009, at 4:45 AM, Greg Stein wrote:
>
>> On Wed, May 6, 2009 at 11:16,  <webpost at tigris dot org> wrote:
>>>
>>> Hi,
>>>
>>> Karl:
>>>>
>>>> Thanks for the patch -- but you may have missed the big thing about
>>>> this issue: that the change can't be made before 2.0, because of
>>>> interface promises.  (Anyway, we'd have to discuss it a lot to change
>>>> it before then.)  That's why the issue is set so far in the future.
>>>
>>> Is there an estimated date for 2.0? Even if the "line" string is bearable
>>> noise for the user, "svn log" still lacks a short summary of the size of a
>>> commit in the style of cvs log "line" field.
>>
>> We have no thoughts on 2.0 at all. That would break compatibility with
>> a huge ecosystem of tools built upon Subversion. Nobody wants to rock
>> the boat that hard, and I don't think it would really be all that
>> great for end-users losing much of their toolset that way.
>>
>>> Couldn't we provide this kind of information by just an extra option to
>>> svn log so that compatibility is preserved?
>>
>> We could, yes. The problem is that we store changes differently from
>> CVS. There is no simple "it changed N lines and added N lines" for a
>> given change (because we do binary deltas -- character by character;
>> we'd have to reconstruct files to detect line-based changes). CVS does
>> this file by file, but we'd want to summarize the whole revision, so
>> we'd have to total these deltas across all files touched by the
>> commit.
>
> I'm not completely familiar with CVS log output, but if you're looking for
> "number of lines added, number of lines removed" type of output, I'd think
> 'svn diff' piped to 'diffstat' would work.  Something like:
>
> $ svn diff -c12345 | diffstat

Sure, but I think he's looking for a quick summary as part of the 'svn
log' output. That diff command over all changed files is relatively
expensive.

I could see a post-commit hook computing that info tho...

Cheers,
-g

« Previous message in topic | 18 of 22 | Next message in topic »

Messages

Show all messages in topic

[Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-20 09:08:14 PDT
     Re: [Issue 2367] get rid of "... | N lines" slot in log message header ghudson Greg Hudson 2005-07-20 09:59:59 PDT
         Re: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-20 11:39:17 PDT
     Re: [Issue 2367] get rid of "... | N lines" slot in log message header nesscg Christopher Ness 2005-07-20 10:55:19 PDT
         Re: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-20 12:09:54 PDT
     Re: [Issue 2367] get rid of "... | N lines" slot in log message header Kevin Puetz <puetzk at puetzk dot org> Kevin Puetz <puetzk at puetzk dot org> 2005-07-20 17:23:09 PDT
     Re: [Issue 2367] get rid of "... | N lines" slot in log message header Max Bowsher <maxb at ukf dot net> Max Bowsher <maxb at ukf dot net> 2005-07-21 08:55:18 PDT
         Re: [Issue 2367] get rid of "... | N lines" slot in log message header davidfaure David Faure 2005-07-21 09:00:19 PDT
             Re: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-21 10:34:16 PDT
                 Re: [Issue 2367] get rid of "... | N lines" slot in log message header davidfaure David Faure 2005-07-22 02:45:17 PDT
                     Re: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-22 08:08:48 PDT
                         Re: [Issue 2367] get rid of "... | N lines" slot in log message header julianfoad Julian Foad 2005-07-22 09:28:54 PDT
                             [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header nesscg Christopher Ness 2005-07-22 17:21:16 PDT
                                 Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-22 17:24:03 PDT
                                     RE: Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header webpost at tigris dot org webpost at tigris dot org 2009-05-06 02:16:25 PDT
                                         Re: Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header gstein Greg Stein 2009-05-06 02:45:23 PDT
                                             Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header hwright Hyrum K. Wright 2009-05-06 05:46:05 PDT
                                                 Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header gstein Greg Stein 2009-05-06 05:50:40 PDT
                                 Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header mattiase Mattias Engdegård 2009-05-06 11:47:57 PDT
                                     RE: Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header webpost at tigris dot org webpost at tigris dot org 2009-05-10 01:50:37 PDT
                 Re: [Issue 2367] get rid of "... | N lines" slot in log message header fw Florian Weimer 2005-07-23 06:55:52 PDT
         Re: [Issue 2367] get rid of "... | N lines" slot in log message header kfogeltest Karl Fogel (test account) 2005-07-21 10:37:31 PDT
Messages per page: