Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svnsync tests may fail to FAIL?

subversion
Discussion topic

Back to topic list

Re: svnsync tests may fail to FAIL?

Author neels
Full name Neels Janosch Hofmeyr
Date 2009-05-22 16:42:27 PDT
Message Stefan Sperling wrote:
> On Sat, May 23, 2009 at 12:49:17AM +0200, Neels Janosch Hofmeyr wrote:
>> Hi all,
>>
>> in svnsync_tests.py, I find these lines in the overall run_test() function:
>>
>> [[[
>> run_sync(dest_sbox.repo_url)
>> run_copy_revprops(de​st_sbox.repo_url)
>> ]]]
>>
>> As I was browsing the output of a test, I noticed that the properties were
>> being synced *twice*. Once by svn_sync(), once by run_copy_revprops().
>>
>> In fact, if I remove the "run_copy_revprops()", all tests still pass fine.
>
> I'd say copying the revprops again is redundant, unless the test
> modifies revprops in the source repository before syncing again.

Yes, but this is a test. It could make sense to run that redundantly, just
to make sure it doesn't fail doing redundant stuff. However, by doing that,
it currently (potentially) obscures all the actual tests.

So, what now -- maybe someone out there already knows what the test suite
should do to test that run_copy_revprops() thing, or someone needs to step
back to pre-r29600 to find out what error that line was trying to catch.

Won't be me right now, though ;)
~Neels
Attachments

« Previous message in topic | 3 of 3 | Next message in topic »

Messages

Show all messages in topic

svnsync tests may fail to FAIL? neels Neels Janosch Hofmeyr 2009-05-22 15:49:22 PDT
     Re: svnsync tests may fail to FAIL? stsp Stefan Sperling 2009-05-22 16:07:47 PDT
         Re: svnsync tests may fail to FAIL? neels Neels Janosch Hofmeyr 2009-05-22 16:42:27 PDT
Messages per page: