Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r37806 - trunk/subversion/libsvn_repos

subversion
Discussion topic

Back to topic list

Re: svn commit: r37806 - trunk/subversion/libsvn_repos

Author hwright
Full name Hyrum K. Wright
Date 2009-05-25 13:01:00 PDT
Message On May 25, 2009, at 2:51 PM, Branko Cibej wrote:

> Hyrum K. Wright wrote:
>> On May 25, 2009, at 9:19 AM, Stefan Sperling wrote:
>>
>>
>>> On Mon, May 25, 2009 at 08:08:17AM -0500, Hyrum K. Wright wrote:
>>>
>>>> On May 24, 2009, at 3:55 PM, Neels Janosch Hofmeyr wrote:
>>>>
>>>>
>>>>> Author: neels
>>>>> Date: Sun May 24 13:55:35 2009
>>>>> New Revision: 37806
>>>>>
>>>>> Log:
>>>>> * subversion/libsvn_re​pos/reporter.c (drive):
>>>>>
>>>> Move the function name to it's own line.
>>>>
>>> HACKING has examples like this:
>>>
>>> * dialects/nightingale.c (get_base_pitch): Allow 3/4-tone
>>> pitch variation to account for trait variability amongst
>>> isolated populations Erithacus megarhynchos.
>>>
>>
>> Oh, so it does.
>>
>> It's been a while since I've seen that format used, and we've seemed
>> to standardize on the "separate line" format. Any objections to
>> changing that example?
>>
>
> Yes. Check the logs, we have hundreds of messages like that. IIRC this
> is even the preferred form according to GNU log message conventions,
> which we liberally stole from. Makes no sense to change Hacking if
> that
> makes tons of our logs "bad', no?

Do you have many recent examples? We also liberally stole from the
GNU coding conventions, but they have evolved to fit our style. Just
as we still have many "spaces before parens" in our code, I'm not
suggesting we "fix" old log messages, but that we pick the format
which is vastly prevalent presently, and standardize on it moving
forward.

But in the end, it's a bikeshed issue, and I've got bigger fish to
fry, so I'm not going to press it. :)

-Hyrum

« Previous message in topic | 6 of 8 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r37806 - trunk/subversion/libsvn_repos hwright Hyrum K. Wright 2009-05-25 07:06:22 PDT
     Re: svn commit: r37806 - trunk/subversion/libsvn_repos stsp Stefan Sperling 2009-05-25 07:19:17 PDT
         Re: svn commit: r37806 - trunk/subversion/libsvn_repos hwright Hyrum K. Wright 2009-05-25 07:24:29 PDT
             Re: svn commit: r37806 - trunk/subversion/libsvn_repos stsp Stefan Sperling 2009-05-25 07:31:55 PDT
             Re: svn commit: r37806 - trunk/subversion/libsvn_repos brane Branko Cibej 2009-05-25 12:51:36 PDT
                 Re: svn commit: r37806 - trunk/subversion/libsvn_repos hwright Hyrum K. Wright 2009-05-25 13:01:00 PDT
                     Re: svn commit: r37806 - trunk/subversion/libsvn_repos brane Branko Cibej 2009-05-25 14:34:29 PDT
             Re: svn commit: r37806 - trunk/subversion/libsvn_repos neels Neels Janosch Hofmeyr 2009-05-26 18:18:32 PDT
Messages per page: