Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r37894 - trunk/subversion/libsvn_subr

subversion
Discussion topic

Back to topic list

Re: svn commit: r37894 - trunk/subversion/libsvn_subr

Author cmpilato
Full name C. Michael Pilato
Date 2009-05-29 12:07:52 PDT
Message Paul T. Burba wrote:
> Author: pburba
> Date: Fri May 29 11:59:01 2009
> New Revision: 37894

[...]

> /* Hmmm. Ideally, we would append to a native-encoding buf
> before starting iteration, then convert back to UTF-8 for
> return. But I suppose that would make the appending code
> sensitive to i18n in a way it shouldn't be... Oh well. */
> - /* ### could alloc in scratch, then copy to result in baton... */
> - SVN_ERR(cstring_from​_utf8(&unique_na​me_apr, unique_name, result_pool));
> + SVN_ERR(cstring_from​_utf8(&unique_na​me_apr, unique_name, scratch_pool));

Do we also need need to dup unique_name_apr to result_pool when we set
baton->name ?

--
C. Michael Pilato <cmpilato at collab dot net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Attachments

« Previous message in topic | 1 of 2 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r37894 - trunk/subversion/libsvn_subr cmpilato C. Michael Pilato 2009-05-29 12:07:52 PDT
     Re: svn commit: r37894 - trunk/subversion/libsvn_subr Paul Burba <ptburba at gmail dot com> Paul Burba <ptburba at gmail dot com> 2009-05-29 12:24:44 PDT
Messages per page: