Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > naming in repos_diff.c

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

naming in repos_diff.c

Author Neels Janosch Hofmeyr <neels at hofmeyr dot de>
Full name Neels Janosch Hofmeyr <neels at hofmeyr dot de>
Date 2009-06-03 13:04:28 PDT
Message Hi Arfrever, Stsp,

would you guys be fine with the attached patch? Calling that thing
"diff_editor" got me confused there for a while.

Furthermore, could you explain why you chuck the local svnpatch_* functions
into an (also local) svn_delta_editor_t in the first place? It makes much
more sense to me to just call them directly without the editor struct.

Thanks,
~Neels
Attachments
no_more_diff_editors.patch
signature.asc

« Previous message in topic | 1 of 11 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
naming in repos_diff.c Neels Janosch Hofmeyr <neels at hofmeyr dot de> Neels Janosch Hofmeyr <neels at hofmeyr dot de> 2009-06-03 13:04:28 PDT
     Re: naming in repos_diff.c e_wong Edmund Wong 2009-06-03 19:15:09 PDT
         Re: naming in repos_diff.c brane Branko Cibej 2009-06-03 21:19:45 PDT
             [OT] channel moderation -- was: Re: naming in repos_diff.c neels Neels Janosch Hofmeyr 2009-06-04 06:25:57 PDT
                 Re: [OT] channel moderation -- was: Re: naming in repos_diff.c stsp Stefan Sperling 2009-06-04 07:25:35 PDT
                     Re: [OT] channel moderation -- was: Re: naming in repos_diff.c brane Branko Cibej 2009-06-04 07:39:29 PDT
                         Re: [OT] channel moderation -- was: Re: naming in repos_diff.c markphip Mark Phippard 2009-06-04 07:43:21 PDT
                         Re: [OT] channel moderation -- was: Re: naming in repos_diff.c cmpilato C. Michael Pilato 2009-06-04 07:43:20 PDT
     Re: naming in repos_diff.c stsp Stefan Sperling 2009-06-04 07:33:46 PDT
         Re: naming in repos_diff.c neels Neels Janosch Hofmeyr 2009-06-04 08:16:20 PDT
             Re: naming in repos_diff.c stsp Stefan Sperling 2009-06-04 08:37:19 PDT
Messages per page: