Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r38306 - in trunk/subversion: include libsvn_wc

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r38306 - in trunk/subversion: include libsvn_wc

Author hwright
Full name Hyrum K. Wright
Date 2009-07-06 08:48:59 PDT
Message On Jul 5, 2009, at 12:39 PM, Greg Stein wrote:

> On Thu, Jul 2, 2009 at 17:33, Hyrum K. Wright<hyrum@hyru​mwright.org>
> wrote:
>> ...
>> +++ trunk/subversion/lib​svn_wc/props.c Thu Jul 2 08:33:34
>> 2009 (r38306)
>> ...
>> @@ -2076,40 +2074,48 @@ svn_wc_prop_set3(const char *name,
>> if (value && svn_prop_is_svn_prop(name))
>> {
>> const svn_string_t *new_value;
>> - struct getter_baton *gb = apr_pcalloc(pool, sizeof(*gb));
>> + struct getter_baton *gb = apr_pcalloc(scratch_pool,
>> sizeof(*gb));
>>
>> - SVN_ERR(svn_dirent_g​et_absolute(&gb-​>local_abspath, path,
>> pool));
>> - gb->db = svn_wc__adm_get_db(adm_access);
>> + gb->local_abspath = local_abspath;
>> + gb->db = wc_ctx->db;
>
> I know you're just tweaking, but this baton can/should just go onto
> the stack rather than the heap.

Good point. r38347.

-Hyrum

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r38306 - in trunk/subversion: include libsvn_wc gstein Greg Stein 2009-07-05 10:39:38 PDT
     Re: svn commit: r38306 - in trunk/subversion: include libsvn_wc hwright Hyrum K. Wright 2009-07-06 08:48:59 PDT
Messages per page: