Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta

subversion
Discussion topic

Back to topic list

Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta

Author julianfoad
Full name Julian Foad
Date 2009-07-11 17:04:55 PDT
Message Neels J Hofmeyr wrote:
> Julian Foad wrote:
> > On Thu, 2009-07-09 at 15:53 -0700, Neels Janosch Hofmeyr wrote:
> >> Enable an atomic replace in editor v2.
> >>
> >> * subversion/include/svn_editor.h
> >> (svn_editor_add_directory_t, svn_editor_add_directory,
> >> svn_editor_add_file_t, svn_editor_add_file,
> >> svn_editor_add_symlink_t, svn_editor_add_symlink,
> >> svn_editor_add_absent_t, svn_editor_add_absent):
> >> Add parameter REPLACES_REV.
> >
> > Where is this parameter documented?

[...]
> It felt kind of silly to only document that parameter in the midst of void.
> And I am too lazy right now to document all of them.

But it's not silly. I can't review the change without knowing what it
means. I'm sure it seems totally obvious to you, but I have questions
about it.

> However, I added a rough description in notes/editor-v2.txt in r38396.

[[[
add_directory(path, children, props, replaces_rev)
  -- name all children. receiver can put on "pending" list
  -- MUST be followed (at some point) by add_*() calls for each child
  -- if replaces_rev isn't SVN_INVALID_REVNUM, this is an atomic
replace.
     Use a revnum because it implies all other info like node kind etc.
]]]

That doesn't actually say what the parameter means. Is it something like
this:

[[[
If replaces_rev is not SVN_INVALID_REVNUM:
(a) This 'add' atomically replaces the node (of kind 'file' or
'directory') that would have existed (if this call and any associated
'delete' call were ignored) at 'path' in the target revision of this
editor drive.
(b) The replaced node-rev must have unbroken history back to revision
'replaces_rev', with no modifications of any kind.
(c) A separate 'delete' of the node that previously existed should not
be issued by the driver, but must be accepted by the receiver (before or
after this call) for backward compatibility.
]]]

?

- Julian

« Previous message in topic | 3 of 22 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta julianfoad Julian Foad 2009-07-10 03:35:24 PDT
     Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta neels Neels Janosch Hofmeyr 2009-07-11 15:34:49 PDT
         Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta julianfoad Julian Foad 2009-07-11 17:04:55 PDT
             Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta neels Neels Janosch Hofmeyr 2009-07-18 14:20:07 PDT
                 Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta julianfoad Julian Foad 2009-07-19 10:53:47 PDT
                     Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta neels Neels Janosch Hofmeyr 2009-07-20 19:31:53 PDT
                         Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta stsp Stefan Sperling 2009-07-21 04:44:44 PDT
                             operation based merging -- was: Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta neels Neels Janosch Hofmeyr 2009-07-21 06:36:04 PDT
                                 Re: operation based merging -- was: Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta stsp Stefan Sperling 2009-07-21 07:44:55 PDT
                                     Re: operation based merging -- was: Re: svn commit: r38394 - in trunk/subversion: include libsvn_delta gavinbaumanis Gavin Baumanis 2009-07-21 16:33:05 PDT
                         Defining atomic "replace" [was: svn commit: r38394 - in trunk/subversion: include libsvn_delta] julianfoad Julian Foad 2009-07-28 03:28:37 PDT
                             Re: Defining atomic "replace" neels Neels Janosch Hofmeyr 2009-08-11 11:53:36 PDT
                                 Re: Defining atomic "replace" gstein Greg Stein 2009-08-11 13:04:12 PDT
                                     Re: Defining atomic "replace" Bill Tutt <bill dot tutt at gmail dot com> Bill Tutt <bill dot tutt at gmail dot com> 2009-08-13 07:41:32 PDT
                                         Re: Defining atomic "replace" julianfoad Julian Foad 2009-08-13 16:24:48 PDT
                                             Re: Defining atomic "replace" Bill Tutt <bill dot tutt at gmail dot com> Bill Tutt <bill dot tutt at gmail dot com> 2009-08-14 11:12:04 PDT
                                 Re: Defining atomic "replace" julianfoad Julian Foad 2009-08-11 16:27:08 PDT
                                     Re: Defining atomic "replace" julianfoad Julian Foad 2009-08-11 16:31:17 PDT
                                     Re: Defining atomic "replace" neels Neels Janosch Hofmeyr 2009-08-12 10:51:43 PDT
                                     no-op-copy -- was: Re: Defining atomic "replace" neels Neels Janosch Hofmeyr 2009-08-12 12:00:55 PDT
                                         Re: no-op-copy -- was: Re: Defining atomic "replace" julianfoad Julian Foad 2009-08-12 17:03:11 PDT
                                             Re: no-op-copy -- was: Re: Defining atomic "replace" neels Neels Janosch Hofmeyr 2009-08-12 17:53:07 PDT
Messages per page: