Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r38429 - in trunk/subversion: libsvn_wc tests/libsvn_wc

subversion
Discussion topic

Back to topic list

Re: svn commit: r38429 - in trunk/subversion: libsvn_wc tests/libsvn_wc

Author gstein
Full name Greg Stein
Date 2009-08-08 10:34:52 PDT
Message On Thu, Jul 16, 2009 at 01:32, Hyrum K. Wright<hyrum@hyru​mwright.org> wrote:
>...
> +++ trunk/subversion/lib​svn_wc/wc-metadata.s​ql  Wed Jul 15 16:32:55 2009        (r38429)
> @@ -311,13 +311,13 @@ CREATE TABLE ACTUAL_NODE (
>   properties  BLOB,
>
>   /* ### do we want to record the revnums which caused this? */
> +  /* ### also, shouldn't these be absolute paths?
> +     ### they aren't currently, but that would be more consistent with other
> +     ### columns. (though it would require a format bump) */

Nope. We only have an abspath in the WCROOT table. Everything else is
a local_relpath, which I believe is Proper for these columns.

And yes, I'd agree that is a format bump. In theory. In actuality,
they are a simple filename, but in per-dir semantics, that is *also* a
local_relpath. IOW, the only real *data* change is when we move to
one-dir semantics. In the meantime, I believe you can start
propagating the notion of local_relpath.

Hmm. Just realized: the OUT params from read_info maybe "should" be
abspath values. Thoughts?

>...

Cheers,
-g

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r38429 - in trunk/subversion: libsvn_wc tests/libsvn_wc gstein Greg Stein 2009-08-08 10:34:52 PDT
Messages per page: