Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH]remove adm_access batons in svn_wc_translated_file3()

subversion
Discussion topic

Back to topic list

Re: [PATCH]remove adm_access batons in svn_wc_translated_file3()

Author yellowflying
Full name HuiHuang
Date 2009-08-10 18:10:11 PDT
Message Hey Julian,

>> * Output files are created in the temp file area belonging to
>> - * @a versioned_file. By default they will be deleted at pool cleanup.
>> + * @a versioned_abspath. By default they will be deleted at scratch_pool cleanup.
>> *
>> * If @c SVN_WC_TRANSLATE_NO_​OUTPUT_CLEANUP is specified, the default
>> - * pool cleanup handler to remove @a *xlated_path is not registered.
>> + * result_pool cleanup handler to remove @a *xlated_path is not registered.

>The first of these two paragraphs refers to "scratch_pool cleanup" and
>the second to "result_pool cleanup". Shouldn't they both refer to the
>same pool?
Originally the function use a single pool for memory allocation while now we use result_pool
for output variables and scratch_pool for the temp.

The temp files are allocated from scratch_pool and xlated_path is allocated from result_pool,
that is why there is difference.

That is what I think about it, is that right?

Thanks for you comment:)
Huihuang
------------------
yellow.flying
2009-08-11

____________________​____________________​__________
赶快注册雅虎超大容量免费邮箱?
http://cn.mail.yahoo.com

« Previous message in topic | 4 of 13 | Next message in topic »

Messages

Show all messages in topic

[PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-09 23:50:09 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() julianfoad Julian Foad 2009-08-10 06:39:22 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() hwright Hyrum K. Wright 2009-08-10 07:36:53 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-10 18:10:11 PDT
         Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() hwright Hyrum K. Wright 2009-08-10 18:18:31 PDT
             Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() julianfoad Julian Foad 2009-08-11 03:31:36 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-10 18:30:46 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-11 23:00:23 PDT
         Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() julianfoad Julian Foad 2009-08-12 04:56:41 PDT
     Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-12 08:18:46 PDT
         Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() julianfoad Julian Foad 2009-08-12 09:41:58 PDT
             Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() julianfoad Julian Foad 2009-08-12 10:37:49 PDT
                 Re: [PATCH]remove adm_access batons in svn_wc_translated_file3() yellowflying HuiHuang 2009-08-13 03:18:19 PDT
Messages per page: