Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Use context_t for svn_wc_cleanup3

subversion
Discussion topic

Back to topic list

Re: [PATCH] Use context_t for svn_wc_cleanup3

Author Paul Burba <ptburba at gmail dot com>
Full name Paul Burba <ptburba at gmail dot com>
Date 2009-08-13 07:58:54 PDT
Message On Thu, Aug 13, 2009 at 10:46 AM, Julian Foad<julianfoad@b​topenworld.com> wrote:
> On Thu, 2009-08-13 at 16:23 +0200, Daniel Näslund wrote:
>> Hi!
>>
>> [ I could not send this message through my ordinary MUA, mutt.
>> My webmail does unfortunately encode all attachments as binary
>> data. Sorry. ]
>>
>> I have run make check with three FAILs:
>> external_tests.py 16: place a file external into a directory external.
>> switch_tests.py 18: switch shouldn't allow changing repos root
>> switch_tests.py 21: forced switch detectes tree conflicts.
>>
>> Reverted all changes, recompiled and the three tests still failed! Can
>> anyone confirm that those tests are failing on trunk?
>
> Yes, I confirm these are failing, both in my own testing and on the
> debian build-bot
> <http://crest.ics.uci​.edu/buildbot/builde​rs/i686-debian-sarge​1%20shared%
> 20gcc-3.3.5/builds/1145>, since last Sunday.
>
> - Julian

I was just looking at the the switch test failures. Both are failing
on Window too, but interestingly the switch fails correctly (i.e. with
no segfault) if the cwd is no higher than the WC's immediate parent:

C:\SVN\src-trunk\​Release\subversion​tests\cmdline\svn​-test-work\working_​copies>svn
switch "file:///C%3A/SVN/sr​c-trunk/Debug/subver​sion/tests/cmdline/s​vn-test-work/reposit​ories/switch_tests-1​8.other/A"
switch_tests-18\A
..\..\..\subversi​on\libsvn_client\s​witch.c:180: (apr_err=170009)
..\..\..\subversi​on\libsvn_client\r​a.c:491: (apr_err=170009)
..\..\..\subversi​on\libsvn_ra\ra_lo​ader.c:497: (apr_err=170009)
..\..\..\subversi​on\libsvn_ra\ra_lo​ader.c:497: (apr_err=170009)
svn: Repository UUID '40da6a90-8424-aa46-​b11c-ee91a6e53134' doesn't
match expected UUID '6f764266-4b7f-9646-​a0bd-7e8d6c022d56'

Go higher than the immediate parent (as the test suite does) and boom:

C:\SVN\src-trunk\​Release\subversion​tests\cmdline\svn​-test-work>svn
switch "file:///C%3A/SVN/sr​c-trunk/Debug/subver​sion/tests/cmdline/s​vn-test-work/reposit​ories/switch_tests-1​8.other/A"
working_copies\swit​ch_tests-18\A
..\..\..\subversi​on\libsvn_client\s​witch.c:180: (apr_err=170009)
..\..\..\subversi​on\libsvn_client\r​a.c:491: (apr_err=170009)
..\..\..\subversi​on\libsvn_ra\ra_lo​ader.c:497: (apr_err=170009)
..\..\..\subversi​on\libsvn_ra\ra_lo​ader.c:497: (apr_err=170009)
svn: Repository UUID '40da6a90-8424-aa46-​b11c-ee91a6e53134' doesn't
match expected UUID '6f764266-4b7f-9646-​a0bd-7e8d6c022d56'
This application has halted due to an unexpected error.
A crash report and minidump file were saved to disk, you can find them here:
C:\DOCUME~1\pburba​\LOCALS~1\Temp\sv​n-crash-log200908130​93953.log
C:\DOCUME~1\pburba​\LOCALS~1\Temp\sv​n-crash-log200908130​93953.dmp
Please send the log file to svn-breakage@subvers​ion.tigris.org to help
us analyse
and solve this problem.

NOTE: The crash report and minidump files can contain some sensitive information
(filenames, partial file content, usernames and passwords etc.)


Looks like r38654* was the offending revision, specifically the change
in libsvn_client/switch​.c:svn_client__switc​h_internal() where
svn_wc__adm_open_anc​hor_in_context() replaced
svn_wc_adm_open_anchor(). Trying out Daniel's patch right now.

Paul

* Bert - Have you looked into this at all?

« Previous message in topic | 3 of 7 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Use context_t for svn_wc_cleanup3 Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-13 07:23:12 PDT
     Re: [PATCH] Use context_t for svn_wc_cleanup3 julianfoad Julian Foad 2009-08-13 07:46:23 PDT
         Re: [PATCH] Use context_t for svn_wc_cleanup3 Paul Burba <ptburba at gmail dot com> Paul Burba <ptburba at gmail dot com> 2009-08-13 07:58:54 PDT
     Re: [PATCH] Use context_t for svn_wc_cleanup3 hwright Hyrum K. Wright 2009-08-13 08:03:17 PDT
         [PATCH v2] Use context_t in svn_wc_cleanup3 Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-14 02:14:18 PDT
             New log message Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-14 02:30:44 PDT
             Re: [PATCH v2] Use context_t in svn_wc_cleanup3 hwright Hyrum K. Wright 2009-08-14 08:54:30 PDT
Messages per page: