Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > [PATCH] Consolidate EOL functions to new libsvn_subr/eol.c

Discussion topic

Back to topic list

[PATCH] Consolidate EOL functions to new libsvn_subr/eol.c

Author e_wong
Full name Edmund Wong
Date 2009-08-17 19:02:07 PDT
Message Hi,

This is my first attempt at a 'large' patch
(in terms of # of files affected).




Moved the EOL functions from the libsvn_subr/subst.c library to
libsvn_subr/eol.c and from include/svn_subst.h to
include/private/svn_​eol_private.h. This is to allow future
consolidation of EOL functions to be placed in the new files
instead of being all over the place.

Changed patch.c, subst-tests.c and diff-file.c to reflect the change
in libraries for svn_subst_find_eol_start(), svn_subst_detect_eol(),
and svn_subst_detect_file_eol(), which have all been renamed to
svn_eol_find_eol_start(), svn_eol_detect_eol() and
svn_eol_detect_file_eol() respectively.

Updated the build.conf to include the new private header

* build.conf:
  (msvc-export): Added private\svn_eol_private.h to end of list.

* subversion/libsvn_di​ff/diff-file.c:
   Include private/svn_eol_private.h

* subversion/libsvn_subr/eol.c: New.

* subversion/include/p​rivate/svn_eol_priva​te.h: New.

* subversion/libsvn_subr/subst.c,
  (svn_subst_find_eol_start, svn_subst_detect_eol,
   svn_subst_detect_file_eol): Moved from here ...

* subversion/libsvn_subr/eol.c,
  (svn_eol_find_eol_start, svn_eol_detect_eol,
   svn_eol_detect_file_eol): ...to here.

* subversion/libsvn_subr/eol.c,
   Included private/svn_eol_private.h,
   Renamed svn_subst_find_eol_start() to svn_eol_find_eol_start(),
   and svn_subst_detect_eol() to svn_eol_detect_eol().

* subversion/tests/lib​svn_subr/subst-test.​c
   Included private/svn_eol_private.h.

Patch by Edmund Wong <ed {at} kdtc.net>
Suggested by: stsp


« Previous message in topic | 1 of 3 | Next message in topic »


Show all messages in topic

[PATCH] Consolidate EOL functions to new libsvn_subr/eol.c e_wong Edmund Wong 2009-08-17 19:02:07 PDT
     Re: [PATCH] Consolidate EOL functions to new libsvn_subr/eol.c stsp Stefan Sperling 2009-08-18 01:35:40 PDT
         Re: [PATCH] Consolidate EOL functions to new libsvn_subr/eol.c crazycat Edmund Wong 2009-08-18 03:22:07 PDT
Messages per page: