Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try)

subversion
Discussion topic

Back to topic list

[PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try)

Author e_wong
Full name Edmund Wong
Date 2009-08-18 04:17:44 PDT
Message Hi,

This is my first attempt at a 'large' patch
(in terms of # of files affected). Also my third
try at sending this patch. Never got my second patch
nor the responses to the first one. I don't get
what's going on.

Edmund

Log:

[[[

Moved the EOL functions from the libsvn_subr/subst.c library to
libsvn_subr/eol.c and from include/svn_subst.h to
include/private/svn_​eol_private.h. This is to allow future
consolidation of EOL functions to be placed in the new files
instead of being all over the place.

Changed patch.c, subst-tests.c and diff-file.c to reflect the change
in libraries for svn_subst_find_eol_start(), svn_subst_detect_eol(),
and svn_subst_detect_file_eol(), which have all been renamed to
svn_eol_find_eol_start(), svn_eol_detect_eol() and
svn_eol_detect_file_eol() respectively.

Updated the build.conf to include the new private header
(svn_eol_private.h).

* build.conf:
  (msvc-export): Added private\svn_eol_private.h to end of list.

* subversion/libsvn_di​ff/diff-file.c:
   Include private/svn_eol_private.h

* subversion/libsvn_subr/eol.c: New.
   Removed superfluous headers that eol.c did not require.

* subversion/include/p​rivate/svn_eol_priva​te.h: New.

* subversion/libsvn_subr/subst.c,
   subversion/include/svn_subst.h:
  (svn_subst_find_eol_start, svn_subst_detect_eol,
   svn_subst_detect_file_eol): Moved from here ...

* subversion/libsvn_subr/eol.c,
   subversion/include/p​rivate/svn_eol_priva​te.h
  (svn_eol_find_eol_start, svn_eol_detect_eol,
   svn_eol_detect_file_eol): ...to here.

* subversion/libsvn_cl​ient/patch.c,
   subversion/libsvn_di​ff/diff-file.c:
   Included private/svn_eol_private.h,
   Renamed svn_subst_find_eol_start() to svn_eol_find_eol_start(),
   and svn_subst_detect_eol() to svn_eol_detect_eol().

* subversion/tests/lib​svn_subr/subst-test.​c:
   Included private/svn_eol_private.h,
   Renamed svn_subst_detect_file_eol() to svn_eol_detect_file_eol().


Patch by Edmund Wong <ed {at} kdtc.net>
Suggested by: stsp

]]]
Attachments

« Previous message in topic | 1 of 8 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) e_wong Edmund Wong 2009-08-18 04:17:44 PDT
     Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) stsp Stefan Sperling 2009-08-18 05:24:19 PDT
         Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) e_wong Edmund Wong 2009-08-18 18:06:48 PDT
             Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) julianfoad Julian Foad 2009-08-19 00:35:15 PDT
                 Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) e_wong Edmund Wong 2009-08-19 17:38:13 PDT
         Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) e_wong Edmund Wong 2009-08-19 17:47:34 PDT
             Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) stsp Stefan Sperling 2009-08-20 01:49:31 PDT
                 Re: [PATCH] Consolidating EOL functions to libsvn_subr/eol.c. (3rd try) e_wong Edmund Wong 2009-08-21 17:38:10 PDT
Messages per page: