Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

subversion
Discussion topic

Back to topic list

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

Author neels
Full name Neels Janosch Hofmeyr
Date 2009-08-23 08:24:16 PDT
Message Martin Hauner wrote:
> I also wonder if I should modify the formatting where the lines get longer
> than 72 characters. There are a lot of other lines that don't strictly follow

Quoting HACKING:
[[[
Restrict lines to 79 columns, so that code will display well in a minimal
standard display window. (There can be exceptions, such as when declaring a
block of 80-column text with a few extra columns taken up by indentation,
quotes, etc., if splitting each line in two would be unreasonably messy.)
]]]

IMHO 76 is nicer, so code can still be indented without redoing the
wrapping. It's not a showstopper, really, if a line gets longer, but it's
nice to adhere to the limit nevertheless.

Martin, just a quick rant: if you do cosmetic changes, it's nice to
- not mix cosmetic changes with functional changes in a patch, and
- group a whole bunch of cosmetic changes in a single patch.

Anyway, if you don't have commit access, I guess it's fine to not bother too
much about cosmetic fixes.

~Neels
Attachments

« Previous message in topic | 17 of 18 | Next message in topic »

Messages

Show all messages in topic

[PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 06:55:18 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:13:57 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 08:56:13 PDT
             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 11:04:43 PDT
                 Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 13:52:57 PDT
                     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gavinbaumanis Gavin Baumanis 2009-09-11 18:07:53 PDT
                         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-09-12 02:23:41 PDT
                             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-12 07:01:23 PDT
                                 Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-13 04:32:01 PDT
                                     Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 00:39:47 PDT
                                         Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool "Martin Hauner" <Martin dot Hauner at gmx dot net> "Martin Hauner" <Martin dot Hauner at gmx dot net> 2009-09-14 04:53:20 PDT
                                             Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 08:59:12 PDT
                                                 Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 03:16:20 PDT
                                                     Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 05:16:48 PDT
                                                         Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 08:14:49 PDT
                                                             Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 10:40:45 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool neels Neels Janosch Hofmeyr 2009-08-23 08:24:16 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:27:47 PDT
Messages per page: