Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

subversion
Discussion topic

Back to topic list

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

Author gstein
Full name Greg Stein
Date 2009-08-23 08:27:47 PDT
Message On Sun, Aug 23, 2009 at 11:21, Neels Janosch Hofmeyr<neels at elego dot de> wrote:
>...
> Martin, just a quick rant: if you do cosmetic changes, it's nice to
> - not mix cosmetic changes with functional changes in a patch, and

There is a balance to this, I think. A cosmetic change here or there
in a functional patch is okay, I think. Just not widespread changes
along with functional changes.

> - group a whole bunch of cosmetic changes in a single patch.

I think this is totally fine. As long as *no* functional changes
occur, then I see no problem with a whole ton of disparate cosmetic
changes.

Cheers,
-g

« Previous message in topic | 18 of 18 | Next message in topic »

Messages

Show all messages in topic

[PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 06:55:18 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:13:57 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 08:56:13 PDT
             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 11:04:43 PDT
                 Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 13:52:57 PDT
                     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gavinbaumanis Gavin Baumanis 2009-09-11 18:07:53 PDT
                         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-09-12 02:23:41 PDT
                             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-12 07:01:23 PDT
                                 Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-13 04:32:01 PDT
                                     Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 00:39:47 PDT
                                         Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool "Martin Hauner" <Martin dot Hauner at gmx dot net> "Martin Hauner" <Martin dot Hauner at gmx dot net> 2009-09-14 04:53:20 PDT
                                             Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 08:59:12 PDT
                                                 Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 03:16:20 PDT
                                                     Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 05:16:48 PDT
                                                         Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 08:14:49 PDT
                                                             Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 10:40:45 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool neels Neels Janosch Hofmeyr 2009-08-23 08:24:16 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:27:47 PDT
Messages per page: