Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

subversion
Discussion topic

Back to topic list

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

Author Martin Hauner <martin dot hauner at gmx dot net>
Full name Martin Hauner <martin dot hauner at gmx dot net>
Date 2009-08-23 08:56:13 PDT
Message Hi Greg,

On 23.08.09 17:13, Greg Stein wrote:
> Hey Martin,
>
> I've always applied a line length of 78. A character in the 79th
> position can cause Emacs (in certain setups) to display a line
> continuation character in position 80, and then nothing on the next
> line. Annoying. But trimming columns to 78 keeps within the "80"
> column limit.

Oh, I thought it was 72. 78 is nice, then there will be less formatting
changes.

> I would suggest files other than log.[ch] -- the loggy subsystem is
> going to be completely removed over the next six weeks.

Ouch, another wasted hour ;-)

> Some of the adm_* files could be a good place to start.

ok, I will consider the log code as a learning session and move on to the adm
files :-)

> And yes: multiple smaller patches is much better than a mother patch.
> You'll be able to get feedback as you go, and start to learn more
> about style and clarification of the goals, rather than waiting until
> "the end" for that info. You'll also be racing time as we make other
> changes to the code, and you'll have a hard time finding somebody
> wanting to review 2000 lines of pool alterations :-)

Yep, exactly what I thought.. :-)


> Cheers,
> -g

--
Martin

Subcommander 2.0.0 Beta 4 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.

« Previous message in topic | 3 of 18 | Next message in topic »

Messages

Show all messages in topic

[PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 06:55:18 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:13:57 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 08:56:13 PDT
             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 11:04:43 PDT
                 Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 13:52:57 PDT
                     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gavinbaumanis Gavin Baumanis 2009-09-11 18:07:53 PDT
                         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-09-12 02:23:41 PDT
                             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-12 07:01:23 PDT
                                 Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-13 04:32:01 PDT
                                     Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 00:39:47 PDT
                                         Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool "Martin Hauner" <Martin dot Hauner at gmx dot net> "Martin Hauner" <Martin dot Hauner at gmx dot net> 2009-09-14 04:53:20 PDT
                                             Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 08:59:12 PDT
                                                 Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 03:16:20 PDT
                                                     Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 05:16:48 PDT
                                                         Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 08:14:49 PDT
                                                             Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 10:40:45 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool neels Neels Janosch Hofmeyr 2009-08-23 08:24:16 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:27:47 PDT
Messages per page: