Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] v4. line_transformer callback

subversion
Discussion topic

Back to topic list

Re: [PATCH] v4. line_transformer callback

Author blair
Full name Blair Zajac
Date 2009-08-27 13:07:26 PDT
Message Stefan Sperling wrote:
> On Thu, Aug 27, 2009 at 01:00:18PM -0700, Blair Zajac wrote:
>>> It took me a second to see that line_transformer_cb is not a type
>>> but the variable name from the previous line. For long lines, we
>>> use something like this style:
>>>
>>> void
>>> svn_stream_set_line_​transformer_callback​
>>> (svn_stream_t *stream,
>>> svn_io_line_transformer_cb_t line_transformer_cb)
>> Oops, make that a two space indent:
>>
>> void
>> svn_stream_set_line_​transformer_callback​
>> (svn_stream_t *stream,
>> svn_io_line_transformer_cb_t line_transformer_cb)
>
> I thought because of no-space-before paren, this would read:
>
> void
> svn_stream_set_line_​transformer_callback​(
> svn_stream_t *stream,
> svn_io_line_transformer_cb_t line_transformer_cb)
>
> Or is this bike-sheddy?

It's bike-sheddy, but I'm following convention in the other header files. In
particular, look through subversion/include/svn_auth.h.

Blair

« Previous message in topic | 26 of 30 | Next message in topic »

Messages

Show all messages in topic

issue 3459 - svn patch does not tolerate empty lines Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-05 13:47:11 PDT
     Re: issue 3459 - svn patch does not tolerate empty lines stsp Stefan Sperling 2009-08-06 05:10:49 PDT
         Re: issue 3459 - svn patch does not tolerate empty lines Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-07 04:40:16 PDT
             Re: issue 3459 - svn patch does not tolerate empty lines stsp Stefan Sperling 2009-08-07 05:23:56 PDT
                 [PATCH] issue 3459 - svn patch does not tolerate empty lines Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-09 12:25:55 PDT
                     Re: [PATCH] issue 3459 - svn patch does not tolerate empty lines Daniel Näslund <daniel at longitudo dot com> Daniel Näslund <daniel at longitudo dot com> 2009-08-13 22:27:29 PDT
                         Re: [PATCH] issue 3459 - svn patch does not tolerate empty lines stsp Stefan Sperling 2009-08-13 23:38:58 PDT
                         Re: [PATCH] issue 3459 - svn patch does not tolerate empty lines gavinbaumanis Gavin Baumanis 2009-08-14 18:27:46 PDT
                             Re: [PATCH] issue 3459 - svn patch does not tolerate empty lines dannas Daniel Näslund 2009-08-15 03:45:20 PDT
                 [PATCH] char_filter_callback for streams dannas Daniel Näslund 2009-08-27 04:44:49 PDT
                     Re: [PATCH] v2. char_filter_callback for streams (or line_transformer) dannas Daniel Näslund 2009-08-27 05:00:43 PDT
                         Re: [PATCH] v2. char_filter_callback for streams (or line_transformer) julianfoad Julian Foad 2009-08-27 07:08:42 PDT
                             Re: [PATCH] v2. char_filter_callback for streams (or line_transformer) julianfoad Julian Foad 2009-08-27 07:17:35 PDT
                             Re: [PATCH] v3. line_transformer callback dannas Daniel Näslund 2009-08-27 09:51:34 PDT
                                 Re: [PATCH] v3. line_transformer callback stsp Stefan Sperling 2009-08-27 11:29:12 PDT
                                     Re: [PATCH] v4. line_transformer callback dannas Daniel Näslund 2009-08-27 12:24:58 PDT
                                         Re: [PATCH] v4. line_transformer callback stsp Stefan Sperling 2009-08-27 12:38:18 PDT
                                             Re: [PATCH] v4. line_transformer callback stsp Stefan Sperling 2009-08-27 12:49:48 PDT
                                                 Re: [PATCH] v4. line_transformer callback stsp Stefan Sperling 2009-08-27 13:22:45 PDT
                                                     line_filter and line_transformer callbacks [was: [PATCH] v4. line_transformer callback] Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-08-28 02:29:29 PDT
                                                         Re: line_filter and line_transformer callbacks [was: [PATCH] v4. line_transformer callback] stsp Stefan Sperling 2009-08-28 03:23:40 PDT
                                                             Re: line_filter and line_transformer callbacks [was: [PATCH] v4. line_transformer callback] Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-08-28 04:05:43 PDT
                                         Re: [PATCH] v4. line_transformer callback blair Blair Zajac 2009-08-27 12:58:27 PDT
                                             Re: [PATCH] v4. line_transformer callback blair Blair Zajac 2009-08-27 13:00:29 PDT
                                                 Re: [PATCH] v4. line_transformer callback stsp Stefan Sperling 2009-08-27 13:04:50 PDT
Page: of 2 « Previous | Next »
Messages per page: