Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r38975 - trunk/subversion/include

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r38975 - trunk/subversion/include

Author blair
Full name Blair Zajac
Date 2009-08-27 17:10:40 PDT
Message Greg Stein wrote:
> On Thu, Aug 27, 2009 at 16:47, Blair Zajac<blair at orcaware dot com> wrote:
>> Author: blair
>> Date: Thu Aug 27 13:47:07 2009
>> New Revision: 38975
>>
>> Log:
>> Coding style tweak.
>>
>> * subversion/include/svn_io.h
>> (svn_stream_set_line​_transformer_callbac​k):
>> Move the arguments onto their own line so there is no lint
>> wrapping of a single argument.
>>
>> Modified:
>> trunk/subversion/inc​lude/svn_io.h
>>
>> Modified: trunk/subversion/inc​lude/svn_io.h
>> URL: http://svn.collab.ne​t/viewvc/svn/trunk/s​ubversion/include/sv​n_io.h?pathrev=38975​&r1=38974&r2​=38975
>> ====================​====================​====================​==================
>> --- trunk/subversion/inc​lude/svn_io.h Thu Aug 27 13:44:13 2009 (r38974)
>> +++ trunk/subversion/inc​lude/svn_io.h Thu Aug 27 13:47:07 2009 (r38975)
>> @@ -765,9 +765,9 @@ svn_stream_set_line_​filter_callback(svn_​
>> * @a line_transformer_cb.
>> * @since New in 1.7. */
>> void
>> -svn_stream_set_line​_transformer_callbac​k(svn_stream_t *stream,
>> - svn_io_line_transformer_cb_t
>> - line_transformer_cb);
>> +svn_stream_set_line​_transformer_callbac​k
>> + (svn_stream_t *stream,
>> + svn_io_line_transformer_cb_t line_transformer_cb);
>
> That parentheses should not have been pulled down to a second line. It
> introduces whitespace between the name and paren (no longer allowed,
> per style), so it doesn't follow current convention. I believe we also
> have some automated scripts that look for function names, and this
> will break those (in trunk/build/).

That's the current standard style throughout the code. If we want to change it,
someone should go through the entire code base and fix it.

Blair

« Previous message in topic | 2 of 6 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r38975 - trunk/subversion/include gstein Greg Stein 2009-08-27 16:25:29 PDT
     Re: svn commit: r38975 - trunk/subversion/include blair Blair Zajac 2009-08-27 17:10:40 PDT
         Re: svn commit: r38975 - trunk/subversion/include gstein Greg Stein 2009-08-27 17:13:32 PDT
             Re: svn commit: r38975 - trunk/subversion/include blair Blair Zajac 2009-08-27 17:20:49 PDT
                 Re: svn commit: r38975 - trunk/subversion/include gstein Greg Stein 2009-08-28 01:17:51 PDT
                     Re: svn commit: r38975 - trunk/subversion/include blair Blair Zajac 2009-08-28 08:55:07 PDT
Messages per page: