Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: reducing code bloat by removing svnpatch? (except unidiff)

subversion
Discussion topic

Back to topic list

Re: reducing code bloat by removing svnpatch? (except unidiff)

Author cmpilato
Full name C. Michael Pilato
Date 2009-08-28 08:07:35 PDT
Message Stefan Sperling wrote:
> On Wed, Aug 26, 2009 at 05:42:30PM +0200, Bert Huijben wrote:
>>> Here is what diffstat has to say about this diff:
>>> include/svn_client.h | 67 -
>>> include/svn_wc.h | 39
>>> libsvn_client/client.h | 11
>>> libsvn_client/deprecated.c | 50 -
>>> libsvn_client/diff.c | 107 --
>>> libsvn_client/merge.c | 3
>>> libsvn_client/patch.c | 1744 --------------------​--------------
>>> ---------
>>> libsvn_client/repos_diff.c | 479 -----------
>>> libsvn_wc/deprecated.c | 3
>>> libsvn_wc/diff.c | 1064 --------------------------
>>> svn/diff-cmd.c | 10
>>> svn/main.c | 28
>>> svn/patch-cmd.c | 4
>>> tests/cmdline/patch_tests.py | 267 ------
>>> 14 files changed, 50 insertions(+), 3826 deletions(-)
>>>
>>> Thoughts? Comments? Should we remove this?
>>> If not, ideas about how to reduce the bloat?
>> As noted earlier, we could use skels instead of a reimplementation of the
>> svn protocol. Other suggestions include implementing an editor driver
>> instead of direct calls into libsvn_wc.
>>
>> In its current state I think it is a big code bloat that will be hard to
>> maintain and I would be +1 on disabling until it is better maintainable.
>
> Any more opinions on this?
>
> Are some people planning to review, or still busy reviewing,
> the implementation to make their judgement, and just need some time?
>
> Please post a short note if you are at all interested in this discussion,
> otherwise I will assume that people don't care, and apply the patch in
> a few days.

Is the plan to remove the support, cut a new branch, and re-add the support
on that branch with a note about the need for refactoring?


--
C. Michael Pilato <cmpilato at collab dot net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Attachments

« Previous message in topic | 5 of 24 | Next message in topic »

Messages

Show all messages in topic

reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-26 08:25:08 PDT
     Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-26 08:41:36 PDT
     RE: reducing code bloat by removing svnpatch? (except unidiff) rhuijben Bert Huijben 2009-08-26 08:41:45 PDT
         Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-28 07:41:18 PDT
             Re: reducing code bloat by removing svnpatch? (except unidiff) cmpilato C. Michael Pilato 2009-08-28 08:07:35 PDT
                 Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-28 08:28:38 PDT
                     Re: reducing code bloat by removing svnpatch? (except unidiff) cmpilato C. Michael Pilato 2009-08-28 08:36:50 PDT
                         Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-28 10:30:30 PDT
                             Re: reducing code bloat by removing svnpatch? (except unidiff) cmpilato C. Michael Pilato 2009-08-28 12:37:11 PDT
                                 Re: reducing code bloat by removing svnpatch? (except unidiff) sussman Ben Collins-Sussman 2009-08-28 17:46:31 PDT
                                     Re: reducing code bloat by removing svnpatch? (except unidiff) markphip Mark Phippard 2009-08-28 18:04:38 PDT
                                         Re: reducing code bloat by removing svnpatch? (except unidiff) Augie Fackler <lists at durin42 dot com> Augie Fackler <lists at durin42 dot com> 2009-08-29 07:54:28 PDT
                                             Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-30 13:09:41 PDT
                                                 Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-09-02 08:08:32 PDT
                                             Re: reducing code bloat by removing svnpatch? (except unidiff) julianfoad Julian Foad 2009-09-02 04:29:33 PDT
                                     Re: reducing code bloat by removing svnpatch? (except unidiff) dannas Daniel Näslund 2009-08-28 22:01:13 PDT
                                         Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-30 13:18:37 PDT
             Re: reducing code bloat by removing svnpatch? (except unidiff) julianfoad Julian Foad 2009-09-01 03:25:22 PDT
                 Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-09-01 04:26:33 PDT
     Re: reducing code bloat by removing svnpatch? (except unidiff) arfrever Arfrever Frehtes Taifersar Arahesis 2009-08-28 15:59:09 PDT
         Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-30 13:11:23 PDT
             Re: reducing code bloat by removing svnpatch? (except unidiff) arfrever Arfrever Frehtes Taifersar Arahesis 2009-08-30 13:18:06 PDT
                 Re: reducing code bloat by removing svnpatch? (except unidiff) stsp Stefan Sperling 2009-08-30 13:41:47 PDT
                     Re: reducing code bloat by removing svnpatch? (except unidiff) markphip Mark Phippard 2009-08-30 14:28:38 PDT
Messages per page: