Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

Author e_wong
Full name Edmund Wong
Date 2009-08-31 19:04:37 PDT
Message Stefan Sperling wrote:
> On Sat, Aug 29, 2009 at 12:39:07PM +0800, Edmund Wong wrote:
>> Since the svn_eol_* functions are in the private
>> headers, Arfrever pointed out that they should be
>> renamed to s/svn_eol_/&_/g.
>
> Some small remarks on the log message:

Even after all these submitted patches, I still can't seem
to get the log right. Quite a disappointment I must say. Sorry about
that.


> You might want to put a short note describing the overall change
> here, unless the change is really trivial. In this case, we could
> say:
>
> "Follow-up to r38983: The new eol functions are supposed to be private,
> not public, so rename them accordingly."
>> * subversion/libsvn_subr/eol.c,
>> subversion/libsvn_di​ff/diff_file.c,
>
> The asterisk alone is a good enough visual hint for the grouping.
> So the indentation isn't needed, and these can all go on the same
> line, like this:
>
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_di​ff/diff_file.c,

I'll keep these in mind.

Edmund

« Previous message in topic | 8 of 10 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
[PATCH] Renaming svn_eol_* functions to svn_eol__*. e_wong Edmund Wong 2009-08-28 21:44:33 PDT
     Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. stsp Stefan Sperling 2009-08-31 03:19:03 PDT
         Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. hwright Hyrum K. Wright 2009-08-31 03:55:57 PDT
             Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. stsp Stefan Sperling 2009-08-31 04:07:15 PDT
                 Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. hwright Hyrum K. Wright 2009-08-31 04:13:25 PDT
                     Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. stsp Stefan Sperling 2009-08-31 04:26:31 PDT
                         Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. hwright Hyrum K. Wright 2009-08-31 05:42:40 PDT
         Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. e_wong Edmund Wong 2009-08-31 19:04:37 PDT
             Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. julianfoad Julian Foad 2009-09-01 03:55:17 PDT
             Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*. stsp Stefan Sperling 2009-09-01 04:06:48 PDT
Messages per page: