Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

subversion
Discussion topic

Back to topic list

Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool

Author gstein
Full name Greg Stein
Date 2009-09-12 02:23:41 PDT
Message Yowza. This patch is spot-on. The comment changes are xlnt, and the
style is perfect. I note that the patch follows precedent of pulling
the two-pools down to its own line in an argument list in a function
call. Very typical of what is seen elsewhere.

And yes... while I said that log.[ch] is headed for the graveyard,
I'll note that hwright is plowing thru the file in order to change a
bunch of callpoints into the lower subsystems. ie. while we're going
to get rid of it eventually, tweaking it now let's us advance the
lower (and upper) levels. Thus, a patch to log.[ch] is very handy.

Martin: sorry for the delay here. The patch looks great, but I doubt
it is going to apply today. Could you update the patch, to be
applicable against trunk, and then I'll review/commit the sucker.

Thanks!
-g


On Fri, Sep 11, 2009 at 21:07, Gavin Baumanis <gavinb at thespidernet dot com> wrote:
> Ping.
> This submission has not received any follow-up.
>
> Please note the patch is attached to the original post of this thread;
> http://subversion.ti​gris.org/ds/viewMess​age.do?dsForumId=462​&dsMessageId=238​6500
>
>
> Gavin.
> On 24/08/2009, at 06:52 , Martin Hauner wrote:
>
>> Hi Greg,
>>
>> On 23.08.09 20:04, Greg Stein wrote:
>>> On Sun, Aug 23, 2009 at 11:56, Martin
>>> Hauner<martin.hau​ner at gmx dot net> ¬†wrote:
>>>> ...
>>>>> I would suggest files other than log.[ch] -- the loggy subsystem is
>>>>> going to be completely removed over the next six weeks.
>>>>
>>>> Ouch, another wasted hour ;-)
>>>
>>> If you're "close" with a patch, then you may as well wrap it up and
>>> send it to the list. It certainly can't hurt to apply it.
>>
>> Yes, it was attached to my first email. :)
>>
>>
>>> Cheers,
>>> -g
>>>
>>
>>
>> --
>> Martin
>>
>> Subcommander 2.0.0 Beta 4 - http://subcommander.tigris.org
>> a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
>>
>> --------------------​--------------------​--------------
>> http://subversion.ti​gris.org/ds/viewMess​age.do?dsForumId=462​&dsMessageId=238​6574
>
> --------------------​--------------------​--------------
> http://subversion.ti​gris.org/ds/viewMess​age.do?dsForumId=462​&dsMessageId=239​3774
>

« Previous message in topic | 7 of 18 | Next message in topic »

Messages

Show all messages in topic

[PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 06:55:18 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:13:57 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 08:56:13 PDT
             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 11:04:43 PDT
                 Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 13:52:57 PDT
                     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gavinbaumanis Gavin Baumanis 2009-09-11 18:07:53 PDT
                         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-09-12 02:23:41 PDT
                             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-12 07:01:23 PDT
                                 Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-13 04:32:01 PDT
                                     Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 00:39:47 PDT
                                         Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool "Martin Hauner" <Martin dot Hauner at gmx dot net> "Martin Hauner" <Martin dot Hauner at gmx dot net> 2009-09-14 04:53:20 PDT
                                             Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 08:59:12 PDT
                                                 Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 03:16:20 PDT
                                                     Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 05:16:48 PDT
                                                         Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 08:14:49 PDT
                                                             Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 10:40:45 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool neels Neels Janosch Hofmeyr 2009-08-23 08:24:16 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:27:47 PDT
Messages per page: