Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] v6. Fix issue 3459.

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: [PATCH] v6. Fix issue 3459.

Author stsp
Full name Stefan Sperling
Date 2009-09-14 12:34:57 PDT
Message On Fri, Sep 11, 2009 at 09:42:40AM +0200, Daniel Näslund wrote:
> There was no patch attached. I was sure I attached one... Trying again.

Thanks so much! I'm really happy to see this fixed because it was
one of my todo items for 1.7.0.

Committed in r39311, and tweaked slightly, both the patch and the
log message. Please refer to the commit to see what I've changed.

One change worth pointing out:

> @@ -376,6 +405,10 @@
> if (starts_with(line->data, atat))
> /* Looks like we have a hunk header, let's try to rip it apart. */
> in_hunk = parse_hunk_header(li​ne->data, *hunk, iterpool);
> +
> + if (in_hunk)
> + original_lines = (*hunk)->original_length;
> +
> else if (starts_with(line->data, minus))
> /* This could be a header of another patch. Bail out. */
> break;

You've changed which 'if' the 'else if' part belongs to! I've fixed this.
I missed this bit in the last round of review, unfortunately.
If in doubt, use { }.

Stefan

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
Re: [PATCH] v6. Fix issue 3459. stsp Stefan Sperling 2009-09-14 12:34:57 PDT
Messages per page: