Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool

subversion
Discussion topic

Back to topic list

Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool

Author gstein
Full name Greg Stein
Date 2009-09-19 10:40:45 PDT
Message On Sat, Sep 19, 2009 at 11:14, Martin Hauner <martin dot hauner at gmx dot net> wrote:
>...
> I'll move on to adm_files.[ch] now if that is ok. Or is there anything more
> useful?

Much of that will become deprecated, so something like copy.c or
status.c would be another good place. But if you'd like to zing out
adm_files, that wouldn't be a problem!

> I have two questions regarding admin_files.[ch]:
>
> - svn_wc_get_adm_dir
>
> Reading the comment I think that it should have both (result/scratch) pools.
> Looking at the implementation it just returns a static. Is it worth here
> splitting the pool?

Nah. Just rename it to result_pool, and be done with it.

>
> - adm_files.[ch]
>
> In most cases there is no comment about the pool usage. Should I add it?

Not in adm_files.h, I'd think. Since they're internal functions, and
the two-pool paradigm is normal/expected, and half of those functions
will probably disappear... I'd say to not go out of your way to adjust
internal doc about dual pools.

Thanks!
-g

« Previous message in topic | 16 of 18 | Next message in topic »

Messages

Show all messages in topic

[PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 06:55:18 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:13:57 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 08:56:13 PDT
             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 11:04:43 PDT
                 Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-08-23 13:52:57 PDT
                     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gavinbaumanis Gavin Baumanis 2009-09-11 18:07:53 PDT
                         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-09-12 02:23:41 PDT
                             Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-12 07:01:23 PDT
                                 Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-13 04:32:01 PDT
                                     Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 00:39:47 PDT
                                         Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool "Martin Hauner" <Martin dot Hauner at gmx dot net> "Martin Hauner" <Martin dot Hauner at gmx dot net> 2009-09-14 04:53:20 PDT
                                             Re: [PATCH] libsvn_wc (log) #2, result_pool/scratch_pool gstein Greg Stein 2009-09-14 08:59:12 PDT
                                                 Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 03:16:20 PDT
                                                     Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 05:16:48 PDT
                                                         Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-19 08:14:49 PDT
                                                             Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool gstein Greg Stein 2009-09-19 10:40:45 PDT
     Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool neels Neels Janosch Hofmeyr 2009-08-23 08:24:16 PDT
         Re: [PATCH] libsvn_wc #1, result_pool/scratch_pool gstein Greg Stein 2009-08-23 08:27:47 PDT
Messages per page: