Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r39507 - trunk/subversion/libsvn_client

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r39507 - trunk/subversion/libsvn_client

Author stylesen
Full name Senthil Kumaran S
Date 2009-09-22 05:19:02 PDT
Message Greg Stein wrote:
> On Tue, Sep 22, 2009 at 05:31, Senthil Kumaran S <senthil at collab dot net> wrote:
>> ...
>> +++ trunk/subversion/lib​svn_client/commit_ut​il.c Tue Sep 22 02:31:19 2009 (r39507)
>> @@ -796,9 +796,10 @@ harvest_committables(apr_hash_t *committ
>> /* A missing, schedule-delete child dir is
>> allowable. Just don't try to recurse. */
>> svn_node_kind_t childkind;
>> - svn_error_t *err = svn_io_check_path(full_path,
>> - &childkind,
>> - iterpool);
>> + svn_error_clear(err);
>> + err = svn_io_check_path(full_path,
>> + &childkind,
>> + iterpool);
>> if (! err
>> && (childkind == svn_node_none)
>> && (this_entry->schedule
>
> That call to svn_error_clear() is wrong. If ERR has a value to be
> cleared, then it should have been done higher in the function, where
> it got set. It should not "simply hang out" and wait for this code to
> clear it. Likewise, if there is no error, then this shouldn't be
> invoked. Worse, this might try to do some kind of double-free which is
> also very bad.

Greg, thanks for catching it, I ve committed a proper fix in r39514. As you
have mentioned, ERR value is cleared higher in the function and this clear is
unnecessary. The 'if ... else' block clears ERR for this part of the code.

Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
Re: svn commit: r39507 - trunk/subversion/libsvn_client gstein Greg Stein 2009-09-22 03:33:25 PDT
     Re: svn commit: r39507 - trunk/subversion/libsvn_client stylesen Senthil Kumaran S 2009-09-22 05:19:02 PDT
Messages per page: