Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r39817 - trunk/subversion/libsvn_wc

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

Re: svn commit: r39817 - trunk/subversion/libsvn_wc

Author gstein
Full name Greg Stein
Date 2009-10-07 15:08:58 PDT
Message As Bert pointed out on IRC... I'm off base here. I was thinking of
svn_wc__entry_versioned().

svn_wc__get_entry() has no hidden concept, so it is always like
SHOW_HIDDEN=TRUE, which the original code did.


On Wed, Oct 7, 2009 at 15:53, Greg Stein <gstein at gmail dot com> wrote:
> On Wed, Oct 7, 2009 at 05:27, Bert Huijben <rhuijben at sharpsvn dot net> wrote:
>>...
>> +++ trunk/subversion/lib​svn_wc/log.c    Wed Oct  7 02:27:15 2009        (r39817)
>>...
>> @@ -597,8 +595,9 @@ log_do_modify_entry(struct log_runner *l
>>          which case we don't want to reincarnate it.  */
>>       const svn_wc_entry_t *existing;
>>
>> -      SVN_ERR(svn_wc_entr​y(&existing, tfile, loggy->adm_access, TRUE,
>> -                           loggy->pool));
>> +      SVN_ERR(svn_wc__get​_entry(&existing​, loggy->db, local_abspath, TRUE,
>> +                                svn_node_unknown, FALSE,
>> +                                loggy->pool, loggy->pool));
>
> Whoops. You changed the SHOW_HIDDEN param value here. Probably not a good idea.
>
>>...
>> @@ -896,9 +885,8 @@ log_do_committed(struct log_runner *logg
>>      entry, or if the entry states that our item is not either "this
>>      dir" or a file kind, perhaps this isn't really the entry our log
>>      creator was expecting.  */
>> -  SVN_ERR(svn_wc_adm_​probe_retrieve(&​adm_access, loggy->adm_access, full_path,
>> -                                    pool));
>> -  SVN_ERR(svn_wc_entr​y(&orig_entry, full_path, adm_access, TRUE, pool));
>> +  SVN_ERR(svn_wc__get​_entry(&orig_ent​ry, loggy->db, local_abspath, FALSE,
>> +                            svn_node_unknown, FALSE, pool, pool));
>
> Here is another change of the SHOW_HIDDEN parameter.
>
>>...
>
> Cheers,
> -g
>

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
Re: svn commit: r39817 - trunk/subversion/libsvn_wc gstein Greg Stein 2009-10-07 12:53:11 PDT
     Re: svn commit: r39817 - trunk/subversion/libsvn_wc gstein Greg Stein 2009-10-07 15:08:58 PDT
Messages per page: