Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Remove 'svnver' array warning in svndiff.c when

subversion
Discussion topic

Back to topic list

Re: [PATCH] Remove 'svnver' array warning in svndiff.c when

Author brane
Full name Branko Cibej
Date 2009-11-04 09:16:05 PST
Message Edmund Wong wrote:
> Hi,
>
> During a Windows compile under VS2008, the following warning is shown:
>
> ..\..\..\subversi​on\libsvn_delta\sv​ndiff.c(193): warning C4295: 'svnver' :
> array is too small to include a terminating null character
>
> Log:
>
> [[[
>
> This patch fixes this misleading assignment. As per notes/svndiff (thanks
> danielsh), svnver = 'SVN\0' where \0 is the format #. The compiler doesn't
> know that and thinks the code is trying to insert another NULL.
>
> * subversion\libsvn_d​elta\svndiff.c
> window_handler: Changed "SVN\0" to {'S','V','N',0}.
>
> Patch by: Edmund Wong <ed{_AT_}kdtc.net>
> Suggested by: rhuijben
>

Hmmm ... That shouldn't be a warning, but on the other hand, using
{"SVN\0"} is just as correct, and easier to read.

Also please use forward slashes for path separators in the log message.

-- Brane

« Previous message in topic | 8 of 9 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Remove 'svnver' array warning in svndiff.c when e_wong Edmund Wong 2009-11-04 08:37:44 PST
     Re: [PATCH] Remove 'svnver' array warning in svndiff.c when Philip Martin <philip dot martin at wandisco dot com> Philip Martin <philip dot martin at wandisco dot com> 2009-11-04 09:09:56 PST
         Re: [PATCH] Remove 'svnver' array warning in svndiff.c when gavinbaumanis Gavin Baumanis 2009-11-10 15:08:13 PST
         Re: [PATCH] Remove 'svnver' array warning in svndiff.c when gavinbaumanis Gavin Baumanis 2009-11-10 15:10:34 PST
             Re: [PATCH] Remove 'svnver' array warning in svndiff.c when julianfoad Julian Foad 2009-11-10 16:43:27 PST
                 Re: [PATCH] Remove 'svnver' array warning in svndiff.c when gavinbaumanis Gavin Baumanis 2009-11-10 17:41:25 PST
             Re: [PATCH] Remove 'svnver' array warning in svndiff.c when e_wong Edmund Wong 2009-11-10 18:39:15 PST
     Re: [PATCH] Remove 'svnver' array warning in svndiff.c when brane Branko Cibej 2009-11-04 09:16:05 PST
     Re: [PATCH] Remove 'svnver' array warning in svndiff.c when rdonch Roman Donchenko 2009-11-11 13:32:40 PST
Messages per page: