Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: svn commit: r40377 - trunk/subversion/libsvn_ra_serf

subversion
Discussion topic

Back to topic list

Re: svn commit: r40377 - trunk/subversion/libsvn_ra_serf

Author Daniel Shahaf <d dot s at daniel dot shahaf dot name>
Full name Daniel Shahaf <d dot s at daniel dot shahaf dot name>
Date 2009-11-05 11:22:08 PST
Message Paul T. Burba wrote on Wed, 4 Nov 2009 at 19:26 -0800:
> Author: pburba
> Date: Wed Nov 4 19:26:27 2009
> New Revision: 40377
>
> Log:
> Follow-up to r38105, fix some diabolical ra_serf failures in the merge tests.
>
> * subversion/libsvn_ra​_serf/util.c
> (svn_ra_serf__handle​_xml_parser): Do not depend on order of evaluation
> of the arguments in the call to svn_error_compose_create() since this is
> not defined by the C standard

This bitten us a few times already. Perhaps we could add a macro that
forces the right order? Or enable a compiler warning for this?

e.g.,

#define svn_error_compose_cr​eate2(errvar1, errvar2, expr1, expr2) \
    (errvar1 = (expr1), errvar2 = (expr2), \
     svn_error_compose_cr​eate(errvar1, errvar2))

#define svn_error_compose_cr​eate2(errvar, expr1, expr2) \
  do { \
    svn_error_t __err1 = (expr1); \
    svn_error_t __err2 = (expr2); \
    errvar = svn_error_compose_cr​eate(__err1, __err2); \
  } while (0)

???

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

Re: svn commit: r40377 - trunk/subversion/libsvn_ra_serf Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-11-05 11:22:08 PST
     Re: svn commit: r40377 - trunk/subversion/libsvn_ra_serf Paul Burba <ptburba at gmail dot com> Paul Burba <ptburba at gmail dot com> 2009-11-06 06:31:40 PST
         Re: svn commit: r40377 - trunk/subversion/libsvn_ra_serf Daniel Shahaf <d dot s at daniel dot shahaf dot name> Daniel Shahaf <d dot s at daniel dot shahaf dot name> 2009-11-06 11:24:19 PST
Messages per page: