Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Fix some deprecation warnings

subversion
Discussion topic

Back to topic list

Re: [PATCH] Fix some deprecation warnings

Author julianfoad
Full name Julian Foad
Date 2009-11-10 05:46:08 PST
Message On Mon, 2009-11-09 at 11:15 +0530, Kannan wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Daniel Rall wrote:
> > On Fri, Nov 6, 2009 at 11:08 AM, Branko ─îibej <brane at xbc dot nu> wrote:
> >> Daniel Rall wrote:
> >>> 2) Why use svn_uri_join() rather than svn_dirent_join()?
> >> uri_join is for paths within the versionable filesystem, and URLs to
> >> entities in a repository. dirent_join is for paths in the WC. As I
> >> learned the hard way.
> >
> > Yep yep.
> >
> > The documentation that I cited, plus the fact that we're in
> > libsvn_client here, makes me think that we're referencing local file
> > system paths; doesn't that mean we want svn_dirent_join()? (And maybe
> > that's what you're getting at.)
>
> Thank you Branko/Daniel, for your comments. DIR entries are relative to
> root of ra session, doesn't that mean we use svn_relpath_join()?

The value of "fs_path" there comes from
svn_client__path_rel​ative_to_root(..., include_leading_slash=TRUE) which
says, "Return the path of ABSPATH_OR_URL relative to the repository root
(REPOS_ROOT) in REL_PATH (URI-decoded)".

The dirent_uri API defines "relpath" as never having a leading slash, so
we can't use svn_relpath_join(). The API does not specify whether a
"uri" is URI-encoded, so we suppose we can use svn_uri_join().

I think that way of using the APIs is not ideal, but it will do for now.

> And for
> the other case(from your comments) use svn_dirent_join() as it points
> only to local absolute paths, or I'm still not getting you?. But the
> 'ls' tests seem to pass for me for the patch I sent, which is odd?

Not sure what "other case" you are referring to.

- Julian

« Previous message in topic | 6 of 11 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Fix some deprecation warnings Kannan <kannanr at collab dot net> Kannan <kannanr at collab dot net> 2009-11-04 01:37:03 PST
     Re: [PATCH] Fix some deprecation warnings dlr Daniel Rall 2009-11-06 11:02:24 PST
         Re: [PATCH] Fix some deprecation warnings brane Branko Cibej 2009-11-06 11:08:05 PST
             Re: [PATCH] Fix some deprecation warnings dlr Daniel Rall 2009-11-06 11:48:07 PST
                 Re: [PATCH] Fix some deprecation warnings Kannan <kannanr at collab dot net> Kannan <kannanr at collab dot net> 2009-11-08 21:46:52 PST
                     Re: [PATCH] Fix some deprecation warnings julianfoad Julian Foad 2009-11-10 05:46:08 PST
                         Re: [PATCH] Fix some deprecation warnings Kannan <kannanr at collab dot net> Kannan <kannanr at collab dot net> 2009-11-10 06:06:50 PST
                             Re: [PATCH] Fix some deprecation warnings julianfoad Julian Foad 2009-11-10 06:44:19 PST
                                 Re: [PATCH] Fix some deprecation warnings Kannan <kannanr at collab dot net> Kannan <kannanr at collab dot net> 2009-11-10 07:25:57 PST
                                     Re: [PATCH] Fix some deprecation warnings julianfoad Julian Foad 2009-11-10 07:45:17 PST
                                         Re: [PATCH] Fix some deprecation warnings julianfoad Julian Foad 2009-11-10 08:10:32 PST
Messages per page: