Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [RFC] Paths API (svn_dirent_uri.h) - improvements

subversion
Discussion topic

Back to topic list

Re: [RFC] Paths API (svn_dirent_uri.h) - improvements

Author stsp
Full name Stefan Sperling
Date 2009-11-11 06:02:48 PST
Message On Wed, Nov 11, 2009 at 01:15:06PM +0000, Julian Foad wrote:
> On Wed, 2009-11-11 at 14:08 +0100, Stefan Sperling wrote:
> > On Wed, Nov 11, 2009 at 12:25:49PM +0000, Julian Foad wrote:
> > > DIRENT:
> > >
> > > A "dirent" represents a native operating-system path... but let's be
> > > clear exactly what kinds of absolute and relative path this includes.
> > >
> > > The representation seems a bit odd, using Subversion's "canonical path"
> > > rules ("/" separator, etc.), rather than the native form, and so
> > > requiring "to_internal_style" and "to_native_style" conversions.
> >
> > One observation I've made recently: On UNIX, passing a path containing
> > backslash-separators (e.g. a path parsed from a patch file) to
> > svn_dirent_internal_style() does absolutely nothing.
> > It just returns the path unmodified.
>
> Isn't that working as designed? A Unix path is allowed to contain
> backslash characters, and they are not treated as path separators, so
> "my\file" is a valid Unix filename, consisting of one component.

Yes, but there's no function that deals with the case where you get
a Windows path on unix and need to normalise it to internal style.

I don't know if dirent_uri should provide that. But I had to cook
a custom hack in libsvn_client/patch.c to deal with this case.

Stefan

« Previous message in topic | 4 of 24 | Next message in topic »

Messages

Show all messages in topic

[RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 04:25:58 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 05:08:20 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 05:15:17 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 06:02:48 PST
                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 06:34:19 PST
                     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 08:46:25 PST
                         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 09:02:07 PST
                             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 11:37:42 PST
                                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 11:48:19 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 05:29:37 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 05:25:23 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 05:33:54 PST
             RE: [RFC] Paths API (svn_dirent_uri.h) - improvements rhuijben Bert Huijben 2009-11-11 05:51:49 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 12:37:01 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 13:26:52 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:07:54 PST
                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:09:31 PST
                     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 14:26:27 PST
                         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:32:46 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-12 06:57:33 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-12 09:02:47 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements rdonch Roman Donchenko 2009-11-11 12:59:36 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 13:10:47 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements rdonch Roman Donchenko 2009-11-11 16:44:20 PST
Messages per page: