Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [RFC] Paths API (svn_dirent_uri.h) - improvements

subversion
Discussion topic

Back to topic list

Re: [RFC] Paths API (svn_dirent_uri.h) - improvements

Author brane
Full name Branko Cibej
Date 2009-11-11 14:26:27 PST
Message Greg Stein wrote:
> On Wed, Nov 11, 2009 at 17:07, Greg Stein <gstein at gmail dot com> wrote:
>
>> On Wed, Nov 11, 2009 at 16:26, Branko ─îibej <brane at xbc dot nu> wrote:
>>
>>> Greg Stein wrote:
>>>
>>>>> * The representation of a URL should be always URI-encoded.
>>>>>
>>>>>
>>>> Yah. That's how we treat them, in general, but having it declared that
>>>> way would be good. As I noted above, we also want them to *always* be
>>>> absolute. The codebase is pretty darned close to allowing for that.
>>>> Also note that the svn_uri_* functions are new in 1.7, so we can
>>>> define them with this restriction.
>>>>
>>>>
>>> Oh hum. That reminds me of my recent changes in svndumpfilter on this
>>> very topic. Svnumpfilter uses "repository-absolute" paths, that is,
>>> paths within the versionable filesystem that always have a leading /.
>>> Clearly those are not dirents; nor are they relpaths; nor, by your
>>> definition above, are they URIs to the intent of the svn_uri API.
>>> They're not URI-encoded, either.
>>>
>>> Which leaves me scratching my head, wondering which of the three
>>> inapplicable families of functions svndumpfilter should be using.
>>>
>> FS is the odd man out. The leading-slash paths don't fit well with
>> much of anything.
>>
>> It would be nice if it used a relpath [from the root].
>>
>
> To expand a bit more...
>
> Bert and I discussed this a few times. Because it isn't a relpath, and
> it isn't a dirent, that is why we use the URI functions for FS paths.
> But once Bert switches on the "must be absolute" bit, then everything
> will fall over. I dunno what his plan was for the FS (he's been
> updating stuff throughout the client, wc, and RA layers).
>
> We never came up with a good solution. Sigh.
>

Why not just drop the must-be-absolute requirement? Those are perfectly
valid URIs, as per spec, they simply lack the schema and server part.

(BTW, URI-encoding them internally is going to cause no end of screaming
horrors. My crystal ball has spoken.)

-- Brane

« Previous message in topic | 18 of 24 | Next message in topic »

Messages

Show all messages in topic

[RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 04:25:58 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 05:08:20 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 05:15:17 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 06:02:48 PST
                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 06:34:19 PST
                     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 08:46:25 PST
                         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 09:02:07 PST
                             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 11:37:42 PST
                                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 11:48:19 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 05:29:37 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 05:25:23 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-11 05:33:54 PST
             RE: [RFC] Paths API (svn_dirent_uri.h) - improvements rhuijben Bert Huijben 2009-11-11 05:51:49 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 12:37:01 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 13:26:52 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:07:54 PST
                 Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:09:31 PST
                     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements brane Branko Cibej 2009-11-11 14:26:27 PST
                         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-11 14:32:46 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements Julian Foad <julian dot foad at wandisco dot com> Julian Foad <julian dot foad at wandisco dot com> 2009-11-12 06:57:33 PST
             Re: [RFC] Paths API (svn_dirent_uri.h) - improvements gstein Greg Stein 2009-11-12 09:02:47 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements rdonch Roman Donchenko 2009-11-11 12:59:36 PST
         Re: [RFC] Paths API (svn_dirent_uri.h) - improvements stsp Stefan Sperling 2009-11-11 13:10:47 PST
     Re: [RFC] Paths API (svn_dirent_uri.h) - improvements rdonch Roman Donchenko 2009-11-11 16:44:20 PST
Messages per page: