Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

subversion
Discussion topic

Back to topic list

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Author Daniel Rall <dlr at collab dot net>
Full name Daniel Rall <dlr at collab dot net>
Date 2007-07-03 09:58:00 PDT
Message On Sun, 01 Jul 2007, D.J. Heap wrote:

> On 7/1/07, Ivan Zhakov <chemodax at gmail dot com> wrote:
...
> >Btw, what do you think about patch itself?
>
> As you and Stefan said, using the API rather than the registry will
> probably be more robust and I think the win32 specific stuff might be
> better off in its own file.

Just a nitpick, but some of the formatting is pretty inconsistent with
the rest of the code base (use of Hungarian notation, lack of
whitespace between data type and value in type casts, etc.).

> I don't have any strong feelings about the temporary memory
> management, but I would tend to prefer a subpool, I think, unless it
> turns out to be a performance issue as Stefan thinks it might.

Is this question in relation to svn_subr__win32_xlat​e_to_stringbuf()?
Attachments

« Previous message in topic | 6 of 35 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-06-30 14:45:41 PDT
     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-06-30 19:18:41 PDT
         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-06-30 19:43:51 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-06-30 23:58:44 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-01 06:06:02 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Daniel Rall <dlr at collab dot net> Daniel Rall <dlr at collab dot net> 2007-07-03 09:58:00 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-04 07:48:13 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 12:48:46 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-05 13:21:09 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2007-07-05 13:23:59 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 08:31:40 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-07 15:32:02 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-07 15:47:49 PDT
                             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 18:47:34 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-08 01:06:47 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 18:32:05 PDT
     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-01 00:13:50 PDT
         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-01 08:31:56 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-01 08:52:52 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-02 04:07:15 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-02 20:49:17 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 02:11:42 PDT
                             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2007-07-05 05:58:48 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 06:07:05 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-05 06:10:53 PDT
Page: of 2 « Previous | Next »
Messages per page: