Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

subversion
Discussion topic

Back to topic list

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

Author chemodax
Full name deleted
Date 2007-07-05 06:07:05 PDT
Message On 7/5/07, Mark Phippard <markphip at gmail dot com> wrote:
> On 7/5/07, Ivan Zhakov <chemodax at gmail dot com> wrote:
> > On 7/3/07, D.J. Heap <djheap at gmail dot com> wrote:
> > > On 7/2/07, Ivan Zhakov <chemodax at gmail dot com> wrote:
> > > [snip]
> > > > Here is revisited patch. Major vhanges from previous version:
> > > > - Use MLang API for converting page name to page id.
> > > > - All Windows stuff moved to separate file win32_xlate.c.
> > > >
> > > > [[[
> > > > Remove APR ICONV dependency on Windows and use native Windows
> > > > character conversion API (MultiByteToWideChar​/WideCharToMultiByte​).
> > > >
> > >
> > >
> > > I've built and posted binaries with this patch at:
> > >
> > > http://subversion.ti​gris.org/servlets/Pr​ojectDocumentList?fo​lderID=8682&expa​ndFolder=8682&fo​lderID=8682
> > >
> > > I still get 2 fs-test failures with VS6 -- haven't had time to dig
> > > into them yet.
> > >
> > > Also, I think we should probably check the return of CoInit and not
> > > call CoUninit if it fails (because CoInit/CoInitEx has already been
> > > called with a different apartment or something).
> > >
> > Good point! I've added check for return value of CoInitialize() and
> > also added logic to detect when COM already initialized for different
> > apartment.
> >
> > I think that patch is acceptable for trunk, thus I've committed it in
> > r25640. Review more than welcome :)
> >
> > On 7/3/07, Daniel Rall <dlr at collab dot net> wrote:
> > > Just a nitpick, but some of the formatting is pretty inconsistent with
> > > the rest of the code base (use of Hungarian notation, lack of
> > > whitespace between data type and value in type casts, etc.).
> > Thanks, I've checked my patch again and fixed what I found.
>
> Thanks Ivan.
>
> Is it possible to build apr-util without iconv now? Or do we still
> have to build apr-iconv and ship the DLL and just know that we are now
> not actually using it?
>
Subversion don't build apr, apr-util and apr-iconv since r24859.
Probably we have to fix packaging scripts.

--
Ivan Zhakov

« Previous message in topic | 24 of 35 | Next message in topic »

Messages

Show all messages in topic

[PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-06-30 14:45:41 PDT
     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-06-30 19:18:41 PDT
         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-06-30 19:43:51 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-06-30 23:58:44 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-01 06:06:02 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Daniel Rall <dlr at collab dot net> Daniel Rall <dlr at collab dot net> 2007-07-03 09:58:00 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-04 07:48:13 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 12:48:46 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-05 13:21:09 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2007-07-05 13:23:59 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 08:31:40 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-07 15:32:02 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-07 15:47:49 PDT
                             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 18:47:34 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-08 01:06:47 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-07 18:32:05 PDT
     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-01 00:13:50 PDT
         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-01 08:31:56 PDT
             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-01 08:52:52 PDT
                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-02 04:07:15 PDT
                     Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) djh D.J. Heap 2007-07-02 20:49:17 PDT
                         Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 02:11:42 PDT
                             Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) Mark Phippard <markphip at gmail dot com> Mark Phippard <markphip at gmail dot com> 2007-07-05 05:58:48 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) chemodax deleted 2007-07-05 06:07:05 PDT
                                 Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help) steveking Stefan Küng 2007-07-05 06:10:53 PDT
Page: of 2 « Previous | Next »
Messages per page: