Login | Register
My pages Projects Community openCollabNet

Discussions > svn > svn commit: r34951 - trunk/subversion/libsvn_fs_fs

subversion
Discussion topic

Back to topic list

svn commit: r34951 - trunk/subversion/libsvn_fs_fs

Author hwright
Full name Hyrum K. Wright
Date 2008-12-26 15:15:56 PST
Message Author: hwright
Date: Fri Dec 26 15:15:59 2008
New Revision: 34951

Log:
Only add representations to the rep-cache which are in the revision being
committed. The issue here is that nodes which have just property mods may
have data reps which are older than the format 4 filesystem, and thus only
have md5 checksums. Attempting to add these nodes to the rep cache results
in errors. This also has the happy side effect of not attempting to add
nodes which do have the sha1 checksum, but which are already in the cache.

* subversion/libsvn_fs_fs/fs_fs.c
  (write_final_rev): Only put a node in the rep cache if it is part of the
    current revision.

Modified:
   trunk/subversion/lib​svn_fs_fs/fs_fs.c

Modified: trunk/subversion/lib​svn_fs_fs/fs_fs.c
URL: http://svn.collab.ne​t/viewvc/svn/trunk/s​ubversion/libsvn_fs_​fs/fs_fs.c?pathrev=3​4951&r1=34950​&r2=34951
====================​====================​====================​==================
--- trunk/subversion/lib​svn_fs_fs/fs_fs.c Fri Dec 26 15:06:11 2008 (r34950)
+++ trunk/subversion/lib​svn_fs_fs/fs_fs.c Fri Dec 26 15:15:59 2008 (r34951)
@@ -5205,7 +5205,8 @@ write_final_rev(const svn_fs_id_t **new_
 
   /* Save the data representation's hash in the rep cache. */
   if (ffd->format >= SVN_FS_FS__MIN_REP_S​HARING_FORMAT
- && noderev->data_rep && noderev->kind == svn_node_file)
+ && noderev->data_rep && noderev->kind == svn_node_file
+ && noderev->data_rep​->revision == rev)
     SVN_ERR(svn_fs_fs__s​et_rep_reference(fs,​ noderev->data_rep, FALSE, pool));
 
   /* Return our ID that references the revision file. */

« Previous message in topic | 1 of 3 | Next message in topic »

Messages

Show all messages in topic

svn commit: r34951 - trunk/subversion/libsvn_fs_fs hwright Hyrum K. Wright 2008-12-26 15:15:56 PST
     Re: svn commit: r34951 - trunk/subversion/libsvn_fs_fs cmpilato C. Michael Pilato 2009-01-05 08:12:01 PST
         Re: svn commit: r34951 - trunk/subversion/libsvn_fs_fs cmpilato C. Michael Pilato 2009-01-05 08:39:30 PST
Messages per page: