Login | Register
My pages Projects Community openCollabNet

Discussions > dev [DISABLED] > libsvn_wc (status.c) result_pool/scratch_pool

subversion
Discussion topic

There will be a brief maintenance window every Friday at 17:00 Pacific.
For further details, see CollabNet's maintenance and upgrade policy.

Back to topic list

libsvn_wc (status.c) result_pool/scratch_pool

Author Martin Hauner <martin dot hauner at gmx dot net>
Full name Martin Hauner <martin dot hauner at gmx dot net>
Date 2009-09-26 10:06:38 PDT
Message Hi,

there is one place in moving libsvn_wc/status.c to result_pool/scratch_pool
where I'm not sure what to do.

status.c has the following function:

static svn_error_t *
close_directory(void *dir_baton,
                 apr_pool_t *scratch_pool)


All pool usages are fine with scratch_pool but a single line looks like a
result_pool:

(currently line 1865)

               eb->anchor_status​->ood_last_cmt_au​thor =
                 apr_pstrdup(pool, db->ood_last_cmt_author);


So close_directory would need both pool parameters. But it is an implementation of:

include/svn_delta.h

   svn_error_t *(*close_directory)(void *dir_baton,
                                   apr_pool_t *pool);


I guess we don't want to change this.. ?

--
Martin

Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.

« Previous message in topic | 1 of 6 | Next message in topic »

Messages

Show all messages in topic

Subject
Author
Full name
Date posted
+
libsvn_wc (status.c) result_pool/scratch_pool Martin Hauner <martin dot hauner at gmx dot net> Martin Hauner <martin dot hauner at gmx dot net> 2009-09-26 10:06:38 PDT
     Re: libsvn_wc (status.c) result_pool/scratch_pool hwright Hyrum K. Wright 2009-09-26 10:12:02 PDT
         Re: libsvn_wc (status.c) result_pool/scratch_pool julianfoad Julian Foad 2009-09-28 03:36:47 PDT
             Re: libsvn_wc (status.c) result_pool/scratch_pool hwright Hyrum K. Wright 2009-09-28 05:14:13 PDT
                 Re: libsvn_wc (status.c) result_pool/scratch_pool julianfoad Julian Foad 2009-09-28 06:13:23 PDT
                 Re: libsvn_wc (status.c) result_pool/scratch_pool dlr Daniel Rall 2009-11-06 13:25:14 PST
Messages per page: